[Compute] BREAKING CHANGE: az vm/vmss create: New VM from existing disk or image #27700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the October 2023 (2023-11-14)❗ Breaking change release ❗ milestone
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
yonzhan,
zhoxing-ms and
yanzhudd
microsoft-github-policy-service
bot
added
the
Compute
|
Compute |
yanzhudd
reviewed
Oct 31, 2023
Comment on lines
616
to
617
| if namespace.security_type is None: | ||
| namespace.security_type = 'TrustedLaunch' |
There was a problem hiding this comment.
It is mentioned in the feature request #23476 Scenario 1:
OS Disk securityProfile has 1-1 mapping with VM, i.e., OS Disk enabled with Trusted Launch can only deploy VM with Trusted Launch.
I think namespace.security_type shoule be set to TrustedLaunch directly without if statement. Hi @AjKundnani could you please help confirm this?
Suggested change
| if namespace.security_type is None: | |
| namespace.security_type = 'TrustedLaunch' | |
| namespace.security_type = 'TrustedLaunch' |
yanzhudd
reviewed
Oct 31, 2023
| @@ -1404,7 +1404,38 @@ def _validate_generation_version_and_trusted_launch(cmd, namespace): | |||
| generation_version = attach_os_disk_info.hyper_v_generation if hasattr(attach_os_disk_info, | |||
| 'hyper_v_generation') else None | |||
| features = attach_os_disk_info.features if hasattr(attach_os_disk_info, 'features') else None | |||
| disk_security_profile = attach_os_disk_info.security_profile if hasattr(attach_os_disk_info, | |||
| 'security_profile') else None | |||
| trusted_launch_warning_log(namespace, generation_version, features) | |||
There was a problem hiding this comment.
This warning message may should be removed
Suggested change
| trusted_launch_warning_log(namespace, generation_version, features) |
yanzhudd
reviewed
Oct 31, 2023
| if disk_security_profile is None: | ||
| return | ||
|
|
||
| from ._constants import UPGRADE_SECURITY_HINT |
There was a problem hiding this comment.
The warning message mentioned in the feature request is:
Consider upgrading security for your workloads using Azure Trusted Launch VMs. To know more about Trusted Launch, please visit https://aka.ms/TrustedLaunch
Hence the link in the UPGRADE_SECURITY_HINT field should be changed from "https://learn.microsoft.com/en-us/azure/virtual-machines/trusted-launch" to "https://aka.ms/TrustedLaunch".
|
For creating VM from existing shared image (Azure Compute Gallery) or managed image using az vm create --image (Scenario 2), corresponding logic should be changed. You can refer to a similar logic with the feature #23614 Scenario 2. |
|
Scenario 3 is similar with Scenario 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Close: #23476
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.