-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[containerapp] az containerapp env create
: Update the default value of --enable-workload-profiles
to True
#27680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpose create;change the value of polling Timeout from 10min to 20min
🔄AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the October 2023 (2023-11-14)❗ Breaking change release ❗ milestone
Oct 25, 2023
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
containerapp env create | cmd containerapp env create update parameter enable_workload_profiles : added property default=True |
microsoft-github-policy-service
bot
requested review from
yonzhan and
wangzelin007
October 25, 2023 07:08
containerapp |
microsoft-github-policy-service
bot
requested review from
yanzhudd,
zhoxing-ms,
jsntcy,
ruslany,
sanchitmehta,
ebencarek,
JennyLawrance,
howang-ms,
vinisoto,
chinadragon0515,
vturecek,
torosent,
pagariyaalok,
Juliehzl and
jijohn14
October 25, 2023 07:08
Juliehzl
reviewed
Oct 25, 2023
...cli/command_modules/containerapp/tests/latest/test_containerapp_workload_profile_commands.py
Show resolved
Hide resolved
The CI pipeline failed due to ofollowing error, could you help to handle it? Thanks!
|
Hi @yanzhudd Could you please help to review and merge this PR? Thanks!! |
Since this is a breaking change, please add "BREAKING CHANGE" to the history notes. |
yanzhudd
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az containerapp env create: --enable-workload-profiles default value change to True
az containerapp compose create: fix containerapp invalid memory resource
Change the value of polling Timeout from 10min to 20min.
Description
Testing Guide
History Notes
[containerapp] BREAKING CHANGE:
az containerapp env create
: Update the default value of--enable-workload-profiles
toTrue
[containerapp]
az containerapp compose create
: Fix containerapp invalid memory resourceThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.