[Search] Add 2023-11-01 support #27632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the October 2023 (2023-11-15)❗ Breaking change release ❗ milestone
❌AzureCLI-BreakingChangeTest
|
|
Search |
kairu-ms
reviewed
Oct 19, 2023
kairu-ms
reviewed
Oct 19, 2023
| g.generic_update_command('update', supports_no_wait=True, custom_func_name='update_search_service', setter_name='begin_create_or_update', setter_arg_name='service') | ||
| g.custom_command('create', 'create_search_service', supports_no_wait=True) | ||
| # g.generic_update_command('update', supports_no_wait=True, custom_func_name='update_search_service', setter_name='begin_create_or_update', setter_arg_name='service') | ||
| # g.custom_command('create', 'create_search_service', supports_no_wait=True) | ||
| g.wait_command('wait') |
There was a problem hiding this comment.
Also need to remove the wait command
kairu-ms
reviewed
Oct 19, 2023
src/azure-cli/azure/cli/command_modules/search/aaz/latest/search/service/__cmd_group.py
Outdated
Show resolved
Hide resolved
kairu-ms
reviewed
Oct 19, 2023
src/azure-cli/azure/cli/command_modules/search/aaz/latest/search/__cmd_group.py
Outdated
Show resolved
Hide resolved
kairu-ms
reviewed
Oct 19, 2023
|
Please fix the CI issues |
mattgotteiner
changed the title
|
@kairu-ms any idea how to change your active subscription for azdev test? az account set --subscription xxx doesn't seem to work |
You can modify subscription id in this file directly |
added 2 commits
October 19, 2023 22:28
worked, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az search
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.