AKS] az aks update: Fix bug where supportPlan can be reset to None
#27554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haitch
requested review from
zhoxing-ms,
andyliuliming,
jsntcy and
yanzhudd
as code owners
🔄AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the October 2023 (2023-11-15)❗ Breaking change release ❗ milestone
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
yonzhan and
FumingZhang
|
AKS bug fix |
haitch
changed the title
az aks update with non-default supportPlan
|
pipeline failure seems all from VM module, not related to my changes. |
FumingZhang
reviewed
Oct 12, 2023
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
reviewed
Oct 17, 2023
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Show resolved
Hide resolved
zhoxing-ms
changed the title
az aks update with non-default supportPlanaz aks update: Fix bug where supportPlan can be reset to None
zhoxing-ms
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks update
Description
support plan could be reset to None during az aks update
Testing Guide
az aks create --kubernetes-version 1.27 --k8s-support-plan AKSLongTermSupport --tier Premium
az aks update --tags "a=b"
az aks update --k8s-support-plan KubernetesOfficial --tier Standard
az aks update --tags "c=d"
az aks update --k8s-support-plan AKSLongTermSupport --tier Premium
History Notes
[AKS]
az aks update: Fix bug where supportPlan can be reset to NoneThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.