{Packaging} Optimize Linux package and docker image by trimming SDK #26172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️acr
🔄acs
🔄advisor
🔄ams
️✔️apim
🔄appconfig
🔄appservice
🔄aro
🔄backup
🔄batch
️✔️batchai
️✔️billing
🔄botservice
🔄cdn
🔄cloud
🔄cognitiveservices
🔄config
🔄configure
️✔️consumption
️✔️container
🔄core
🔄cosmosdb
🔄databoxedge
🔄dla
🔄dls
️✔️dms
️✔️eventgrid
🔄eventhubs
🔄feedback
🔄find
🔄hdinsight
️✔️identity
️✔️iot
🔄keyvault
️✔️kusto
️✔️lab
🔄managedservices
🔄maps
️✔️marketplaceordering
️✔️monitor
🔄netappfiles
️✔️network
🔄policyinsights
️✔️privatedns
🔄profile
🔄rdbms
🔄redis
🔄relay
️✔️resource
️✔️role
️✔️search
🔄security
🔄servicebus
🔄serviceconnector
🔄servicefabric
🔄signalr
️✔️sql
🔄sqlvm
🔄storage
️✔️synapse
🔄telemetry
🔄util
🔄vm
|
azure-client-tools-bot-prd
bot
added this to the May 2023 (2023-05-23) - For Build (Breaking change release) milestone
|
Hi @bebound, |
|
Packaging |
bebound
changed the title
bebound
requested review from
kairu-ms,
jiasli,
wangzelin007 and
calvinhzy
as code owners
3 tasks
jiasli
reviewed
Apr 18, 2023
scripts/release/rpm/azure-cli.spec
Outdated
Comment on lines
55
to
56
| # Remove unused SDK version | ||
| %{python_cmd} %{repo_path}/scripts/trim_sdk.py |
There was a problem hiding this comment.
How about we move this line after L50 to align with Dockerfile?
bebound
force-pushed
the
linux-remove-sdk
branch
from
73e51d2
to
80506cf
Compare
jiasli
approved these changes
Apr 19, 2023
|
Nice work! This certainly improves #7387 a lot! |
|
This is a great achievement. |
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have used
trim_sdk.pyand only keep pyc file on Windows. Apply them on Linux and docker to reduce package size.This is the first part, use trim_sdk on Linux.
Using pyc is #25801
Result:
Ubuntu 22.04 installed size: 965MB -> 576 MB, become 60% of original size.
RHEL 9 installed size 771MB -> 403 MB, become 52% of original size.
Docker 1328MB -> 952MB, become 72% of original size.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.