[Compute] az disk create: --gallery-image-reference adds support for creating disk from shared gallery image version or community gallery image version
#22756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… need to be checked
yanzhudd
requested review from
zhoxing-ms,
jsntcy,
wangzelin007,
jiasli,
evelyn-ys,
kairu-ms and
calvinhzy
as code owners
ghost
requested a review
from 
ghost
added
the
|
Compute |
zhoxing-ms
reviewed
Jun 7, 2022
zhoxing-ms
reviewed
Jun 7, 2022
zhoxing-ms
reviewed
Jun 7, 2022
zhoxing-ms
reviewed
Jun 7, 2022
Comment on lines
1043
to
1044
| community_gallery_image_version = '/CommunityGalleries/' + public_name + '/Images/' + self.kwargs['image1'] \ | ||
| + '/Versions/' + self.kwargs['version'] |
There was a problem hiding this comment.
After feature #21423 is completed, community_gallery_image_version can be obtained from the sig image-version show-community command instead
zhoxing-ms
changed the title
az disk create: Add two supported formats of --gallery-image-reference to support creating disk from shared gallery image version and community gallery image versionaz disk create: The parameter --gallery-image-reference adds support for creating disk from shared gallery image version or community gallery image version
zhoxing-ms
changed the title
az disk create: The parameter --gallery-image-reference adds support for creating disk from shared gallery image version or community gallery image versionaz disk create: --gallery-image-reference adds support for creating disk from shared gallery image version or community gallery image version
zhoxing-ms
changed the title
az disk create: --gallery-image-reference adds support for creating disk from shared gallery image version or community gallery image versionaz disk create: --gallery-image-reference adds support for creating disk from shared gallery image version or community gallery image version
zhoxing-ms
approved these changes
Jun 21, 2022
…k_for_two_galleries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add two supported formats of
--gallery-image-referenceargument inaz disk createscenario to support creating disk from shared gallery image version and community gallery image version.Close #22425
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.