Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Packaging} Bump setuptools to 52.0.0 #16655

Merged
merged 1 commit into from
Mar 1, 2021
Merged

{Packaging} Bump setuptools to 52.0.0 #16655

merged 1 commit into from
Mar 1, 2021

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Jan 25, 2021

Description
Bump setuptools to 52.0.0 for Python 3.9 support.

On Python 3.9, pip install -e D:\cli\azure-cli/src/azure-cli-telemetry --no-deps fails with setuptools 40.0.0:

Obtaining file:///D:/cli/azure-cli/src/azure-cli-telemetry
    ERROR: Command errored out with exit status 1:
     command: 'D:\cli\env39\Scripts\python.exe' -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'D:\\cli\\azure-cli\\src\\azure-cli-telemetry\\setup.py'"'"'; __file__='"'"'D:\\cli\\azure-cli\\src\\azure-cli-telemetry\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base 'C:\Users\jiasli\AppData\Local\Temp\pip-pip-egg-info-s2_jb1ye'
         cwd: D:\cli\azure-cli\src\azure-cli-telemetry\
    Complete output (11 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "D:\cli\env39\lib\site-packages\setuptools\__init__.py", line 14, in <module>
        from setuptools.dist import Distribution, Feature
      File "D:\cli\env39\lib\site-packages\setuptools\dist.py", line 24, in <module>
        from setuptools.depends import Require
      File "D:\cli\env39\lib\site-packages\setuptools\depends.py", line 7, in <module>
        from .py33compat import Bytecode
      File "D:\cli\env39\lib\site-packages\setuptools\py33compat.py", line 55, in <module>
        unescape = getattr(html, 'unescape', html_parser.HTMLParser().unescape)
    AttributeError: 'HTMLParser' object has no attribute 'unescape'
    ----------------------------------------
WARNING: Discarding file:///D:/cli/azure-cli/src/azure-cli-telemetry. Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

This was fixed by pypa/setuptools#1788.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 25, 2021

Packaging

@yonzhan yonzhan requested a review from fengzhou-msft January 25, 2021 06:11
@yonzhan yonzhan added this to the S182 milestone Jan 25, 2021
@jiasli jiasli marked this pull request as ready for review January 25, 2021 07:45
@fengzhou-msft
Copy link
Member

Is this new version compatible with python 3.6, 3.7 and 3.8?

@yonzhan yonzhan modified the milestones: S182, S183 Feb 6, 2021
@jiasli
Copy link
Member Author

jiasli commented Feb 20, 2021

Is this new version compatible with python 3.6, 3.7 and 3.8?

Should be. Haven't seen any issue in CI yet.

@yonzhan yonzhan modified the milestones: S183 - For Ignite, S184 Feb 26, 2021
@yonzhan yonzhan requested review from jsntcy and evelyn-ys February 26, 2021 15:09
@kairu-ms
Copy link
Contributor

kairu-ms commented Mar 1, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jiasli jiasli merged commit 99c5fb4 into Azure:dev Mar 1, 2021
@jiasli jiasli deleted the setuptools branch March 1, 2021 02:41
@@ -1,3 +1,3 @@
# basic
setuptools==40.0.0
setuptools==52.0.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to this line, the dev environment uses setuptools 52.0.0 but the MSI uses the latest, causing inconsistent behavior (#24982 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants