rbac: remove usages of session key as it offers no guarantee for reliable graph read #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yugangw-msft
force-pushed
the
cleanuprbac
branch
from
a2fbfe5 to
7799a8d
Compare
|
/cc:@derekbekoe, could we get it reviewed? I would like this gets included in today's public drop. Thanks! |
tjprescott
added
Account
|
Were we actually using this or was it put in place for flexibility? At first I thought this was an exposed parameter and thus removing it was a breaking change, but it looks like it was an internal implementation detail and not used. |
tjprescott
approved these changes
Dec 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to work for first party applications like cli, but now AAD service no longer support it.
Hence I am cleaning up the code and just use retries.