[ACR] Prefix storage account name with registry name #1417
Conversation
djyou
commented
Nov 22, 2016
•
djyou
commented
- Prefix storage account name with registry name.
- Add tags to storage account.
- Add registry name validation to avoid creating storage account when registry name is not available.
|
@djyou, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DavidObando, @skkestrel and @troydai to be potential reviewers. |
| @@ -3,6 +3,9 @@ | |||
| # Licensed under the MIT License. See License.txt in the project root for license information. | |||
| # -------------------------------------------------------------------------------------------- | |||
|
|
|||
| from random import choice | |||
| from string import digits | |||
There was a problem hiding this comment.
if these two references are used in random_storage_account_name only, please move them into the method.
| if storage_client.check_name_availability(storage_account_name).name_available: #pylint: disable=no-member | ||
| return storage_account_name[:24] | ||
| else: | ||
| return random_storage_account_name(registry_name, storage_client) |
There was a problem hiding this comment.
prefer loop instead of recursive.
| if storage_client is None: | ||
| storage_client = get_storage_service_client().storage_accounts | ||
|
|
||
| random_suffix = ''.join(choice(digits) for i in range(3)) |
There was a problem hiding this comment.
the randomness here doesn't seem to be sufficient to me. chance of conflict is fairly high comparing to the original uuid approach. if the what actually needed is 'uniqueness' rather than 'randomness' what about using a simple timestamp here?
datetime.utcnow().strftime('%Y%m%d%H%M%S')
|
/cc @sajayantony |
|
/cc @SteveLas |
djyou
changed the title
1. Use time stamp as storage account name suffix 2. Add registry name validation to avoid creating dependency resource 3. Move default storage account type to template
djyou
force-pushed
the
doyou/storagename
branch
from
4228e1f to
9192284
Compare
|
@tjprescott @derekbekoe Can we have this merged if there is no more comment? Thanks. |
1. Use time stamp as storage account name suffix 2. Add registry name validation to avoid creating dependency resource 3. Move default storage account type to template
