Support packaging as .whl files #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,7 +32,7 @@ def build_package(path_to_package, dist_dir): | |||
| print_heading('Building {}'.format(path_to_package)) | |||
| path_to_setup = os.path.join(path_to_package, 'setup.py') | |||
| set_version(path_to_setup) | |||
| cmd_success = exec_command('python setup.py sdist -d {}'.format(dist_dir), cwd=path_to_package) | |||
| cmd_success = exec_command('python setup.py sdist bdist_wheel -d {}'.format(dist_dir), cwd=path_to_package) | |||
There was a problem hiding this comment.
Just a question, is it worthwhile to produce both packages?
There was a problem hiding this comment.
Yes they recommend creating both and uploading both.
|
LGTM |
derekbekoe
force-pushed
the
package_bdist
branch
from
9df5c5a to
f6da85d
Compare
derekbekoe
changed the title
derekbekoe
changed the title
derekbekoe
changed the title
|
I've verifying the change a bit more before merging. |
derekbekoe
force-pushed
the
package_bdist
branch
from
4eafe70 to
f378046
Compare
- Update package-verify and nightly-build to use bdist_wheel also
derekbekoe
force-pushed
the
package_bdist
branch
from
f378046 to
81fa6f2
Compare
derekbekoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When publishing on PyPI, we should publish both .tar.gz and .whl files.
Add setup.cfg files