CLI Update for Azure Stack HCI 2022-05-01 Release

[lsweeney24]

Resource Provider

AzureStackHCI

Description of Feature or Work Requested

We want to update our CLI based on the swagger.

Swagger and PR link
https://github.com/Azure/azure-rest-api-specs/tree/main/specification/azurestackhci/resource-manager/Microsoft.AzureStackHCI/stable/2022-05-01

Azure/azure-rest-api-specs#18851

Target Date
May 31, 2022

[yonzhan]

AzureStackHCI

[zhoxing-ms]

@lsweeney24 Hi, since our work in this sprint has been fully arranged, we don't have enough time to support more requirements. Can this feature request be postponed to the release of the next sprint (08-02)?

[zhoxing-ms]

@lsweeney24 I‘d like to confirm with you whether we only need to upgrade the api-version for Microsoft.AzureStackHCI or we need to add new commands/parameters?

[lsweeney24]

Hello, We will need both an Api version upgrade and new commands. Here is an example of the desired changes based on the PowerShell cmdlets we just had released - Azure/azure-powershell#18559 [https://opengraph.githubassets.com/8efb8043bef1d804aa3076fb337df9540e5b0825f5723cc4b0d9b5c305dcecc0/Azure/azure-powershell/pull/18559]<https://github.com/Azure/azure-powershell/pull/18559> Generation of the stackhci ps cmdlets by lsweeney24 · Pull Request #18559 · Azure/azure-powershell<Azure/azure-powershell#18559> Description Using autorest to automatically create the cmdlets for the stackhci rp. Adding in tests for all cmdlets exposed to a customer. Checklist I have read the Submitting Changes section of ... github.com Thanks, Luke

…

________________________________ From: Xing Zhou ***@***.***> Sent: Sunday, July 3, 2022 10:37 PM To: Azure/azure-cli ***@***.***> Cc: Luke Sweeney ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/azure-cli] CLI Update for Azure Stack HCI 2022-05-01 Release (Issue #22470) @lsweeney24<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flsweeney24&data=05%7C01%7CLuke.Sweeney%40microsoft.com%7Cc139b117909846114fd908da5d661e59%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637924990428258578%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=D8sY4%2Fe8VtkUH4jqODSYjCNrMY3iM8QvF7bnuIJEIGI%3D&reserved=0> I‘d like to confirm with you whether we only need to upgrade the api-version for Microsoft.AzureStackHCI or we need to add new commands/parameters? — Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-cli%2Fissues%2F22470%23issuecomment-1173275633&data=05%7C01%7CLuke.Sweeney%40microsoft.com%7Cc139b117909846114fd908da5d661e59%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637924990428258578%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=1Ft1tFOZAHLrvtHUpTaqXqe9u822%2FXB5pvFV09ZQ4WU%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYSF3H4QOI25ZYUWSKNZX33VSJE57ANCNFSM5WBYSQKA&data=05%7C01%7CLuke.Sweeney%40microsoft.com%7Cc139b117909846114fd908da5d661e59%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637924990428258578%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=27%2Fw7hbvKZrbmgZXQ2uwm7JTGcQNPwg3xot%2FO2aSTno%3D&reserved=0>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[Jing-song]

Hi @lsweeney24 , when creates a Stack HCI cluster, how to get CloudManagementEndpoint in CLI, we need to add automated tests for it
request body

[lsweeney24]

Hello, For the AAD tenant id this is just the value for the tenant you would be testing in example “"AadTenantId": "72f988bf-86f1-41af-91ab-2d7cd011db47",”. For the AAD client id this can be any GUID string for testing purposes but it must be a valid GUID. Lately, the CloudManagementEndpoint is an optional parameter, but this would just be the ARM endpoint for that region, example “https://management.azure.com/” Thanks, Luke Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: songlu ***@***.***> Sent: Tuesday, July 19, 2022 11:11:44 PM To: Azure/azure-cli ***@***.***> Cc: Luke Sweeney ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/azure-cli] CLI Update for Azure Stack HCI 2022-05-01 Release (Issue #22470) Hi @lsweeney24<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flsweeney24&data=05%7C01%7CLuke.Sweeney%40microsoft.com%7C6085505c740a4252788908da69fd9375%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637938835073527650%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=StIIhS6HrAsoGMNvEDgdnu2mUCmFmQSP4cbm%2BsQHeVU%3D&reserved=0> , when creates a Stack HCI cluster, how to get AadTenantId, AadClientId and CloudManagementEndpoint <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-powershell%2Fpull%2F18559%2Ffiles%23diff-108d24ddc4d9bec48b817e51e432e54b9d5b46210a0ffa9bcac70106f35e3420&data=05%7C01%7CLuke.Sweeney%40microsoft.com%7C6085505c740a4252788908da69fd9375%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637938835073527650%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RIjWKnlbOP39tg1nDZ%2FpqU%2FpWo0t%2Bn1dHEqsOqQRBMk%3D&reserved=0> in CLI, we need to add automated tests for it request body<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fblob%2Fmain%2Fspecification%2Fazurestackhci%2Fresource-manager%2FMicrosoft.AzureStackHCI%2Fstable%2F2022-05-01%2Fexamples%2FCreateCluster.json%23L10-L12&data=05%7C01%7CLuke.Sweeney%40microsoft.com%7C6085505c740a4252788908da69fd9375%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637938835073527650%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TrOMwQ9wsATt2wSvHJwIRoqrnngrT7BMASTjttuCiIU%3D&reserved=0> — Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-cli%2Fissues%2F22470%23issuecomment-1189763006&data=05%7C01%7CLuke.Sweeney%40microsoft.com%7C6085505c740a4252788908da69fd9375%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637938835073527650%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=BhCapLeke%2FRl2BpOvTSB%2Fa1Q6Y4hCvVW7jnHwpCVhXk%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYSF3H5KY4UJYKCBAD6F2LTVU5U7BANCNFSM5WBYSQKA&data=05%7C01%7CLuke.Sweeney%40microsoft.com%7C6085505c740a4252788908da69fd9375%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637938835073683874%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4PxCwFtsGzH%2BF923WlH0HzAYe618NO13pI7HrmhEGvs%3D&reserved=0>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[Jing-song]

Hi @lsweeney24 , The return value of az stack-hci cluster upload-certificate and az stack-hci extension update form service is wrong(Operation returned an invalid status 'OK', error), could you please fix it, or remove it as before?

[lsweeney24]

Hello, we don’t need these cmdlets implemented, so that is ignorable. Here is a reference to what cmdlets we are looking for Using this PR - Azure/azure-powershell#18559, the cmdlets we don’t want are “Update-AzStackHciExtension”, “Invoke-AzStackHciUploadClusterCertificate”, “New-AzStackHciArcSettingPassword”, “Update-AzStackHciArcSetting”. The rest from the Swagger spec are good. Thanks, Luke Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: songlu ***@***.***> Sent: Monday, July 25, 2022 3:43:28 AM To: Azure/azure-cli ***@***.***> Cc: Luke Sweeney ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/azure-cli] CLI Update for Azure Stack HCI 2022-05-01 Release (Issue #22470) Hi @lsweeney24<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flsweeney24&data=05%7C01%7CLuke.Sweeney%40microsoft.com%7C2bca0a74e1734f179ef808da6e115d95%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637943318110795158%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=x3MSyuQjy3LANtGI6hwJDhQw62cFJvLivryf6rrWNSM%3D&reserved=0> , The return value of az stack-hci cluster upload-certificate and az stack-hci extension update form service is wrong(Operation returned an invalid status 'OK', error<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-cli-extensions%2Fpull%2F5132%2Ffiles%23diff-bd591a247bc308f09abca52167a77d46d49e40aca784c6f4a3aceeda513138df&data=05%7C01%7CLuke.Sweeney%40microsoft.com%7C2bca0a74e1734f179ef808da6e115d95%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637943318110795158%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=v6ip%2FkLF%2FzIF%2BPaTQc9gMgk6D2a7yVbA5JsYRydplVg%3D&reserved=0>), could you please fix it, or remove it as before? — Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-cli%2Fissues%2F22470%23issuecomment-1193698919&data=05%7C01%7CLuke.Sweeney%40microsoft.com%7C2bca0a74e1734f179ef808da6e115d95%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637943318110795158%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZgHhYdLJZNbpOkadVf5SjOhv7tkDvgFb3XdQSWN1k%2Bk%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYSF3H67XBEIFNIJG3YH5FLVVZASBANCNFSM5WBYSQKA&data=05%7C01%7CLuke.Sweeney%40microsoft.com%7C2bca0a74e1734f179ef808da6e115d95%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637943318110795158%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2BSxDIViGWvOJf1n8Sgu5gk8IlOBbn66EZymLzGEdE2s%3D&reserved=0>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[lsweeney24]

Hello, We will want certain commands not included but the rest from the Swagger spec are fine. Using this PR - Azure/azure-powershell#18559, the cmdlets we don't want are "Update-AzStackHciExtension", "Invoke-AzStackHciUploadClusterCertificate", "New-AzStackHciArcSettingPassword", "Update-AzStackHciArcSetting". The rest from the Swagger spec are good. Thanks, Luke From: Xing Zhou ***@***.***> Sent: Wednesday, July 6, 2022 11:22 PM To: Azure/azure-cli ***@***.***> Cc: Luke Sweeney ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/azure-cli] CLI Update for Azure Stack HCI 2022-05-01 Release (Issue #22470) @lsweeney24<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flsweeney24&data=05%7C01%7CLuke.Sweeney%40microsoft.com%7Cbaf855e4ec0346b7d53b08da5fc7ce3a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637927609006478847%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=04awUAaGWOpMd7gGKQI4YUktfoa5CKmq4n66lIoCbG8%3D&reserved=0> May I ask do you want CLI to add some new specific commands, or do you want CLI to support all the contents defined in Swagger? - Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-cli%2Fissues%2F22470%23issuecomment-1177006862&data=05%7C01%7CLuke.Sweeney%40microsoft.com%7Cbaf855e4ec0346b7d53b08da5fc7ce3a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637927609006478847%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=zUT7aj%2FQlJSjiO0SHJEGV2VwJ6yDz1D0g44ASZlJJMU%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYSF3H5XPAHIZKZJ45UT7YDVSZEMFANCNFSM5WBYSQKA&data=05%7C01%7CLuke.Sweeney%40microsoft.com%7Cbaf855e4ec0346b7d53b08da5fc7ce3a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637927609006478847%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Gr7AQjV63CiSFQCDiktKC%2FDb5mfb%2FCy66%2B%2FYnAuYg3E%3D&reserved=0>. You are receiving this because you were mentioned.Message ID: ***@***.***>