K8s extension/release 1.5.0 #6779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First draft for Data Protection K8s backup extension (Pending internal review) * Removing tracing * Minor changes to improve azdev style * Internal PR review feedback Co-authored-by: Rishabh Raj <rishraj@microsoft.com>
…ad of workspace (#175) * fix: Update DCR creation to Clusters resource group instead of workspace * . * . * casing check
adding the api version to the operation definition in the client factory
bump k8s-extension version to 1.3.6
…n expected by the service
…tests adding tests for all 4 extension types calls
…into release-1.3.6
…tensiontypetests adding upstream test for extension types
…into release-1.3.6
…into release-1.3.6
…eate (#188) * Add more validations and user prompt for existing installation scenario Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Add Dapr test' Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Handle stateful set Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Update default handling Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Fix HA handling Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Add placement service todo Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Add non-interactive mode Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Fix lint Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Update tests Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Reset configuration for StatefulSet during k8s upgrade Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Fix lint Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Retrigger tests Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Add changes to manage ha and placement params Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Update message Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * nits Signed-off-by: Shubham Sharma <shubhash@microsoft.com> Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
bump k8s-extension version to 1.5.0
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @Arif-lakhani, |
|
Hi @Arif-lakhani, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
add deprecated params for extension types
Arif-lakhani
force-pushed
the
k8s-extension/release-1.5.0
branch
from
073751f to
ac3a9bb
Compare
|
Could you please add some change details in the PR description #6779 (comment)? |
yanzhudd
reviewed
Sep 25, 2023
Add breaking change details to the history
Arif-lakhani
force-pushed
the
k8s-extension/release-1.5.0
branch
from
ac3a9bb to
10e1709
Compare
yanzhudd
reviewed
Sep 27, 2023
yanzhudd
reviewed
Sep 27, 2023
| # -------------------------------------------------------------------------- | ||
|
|
||
| VERSION = "2.0.0" | ||
| VERSION = "0.1.0" |
There was a problem hiding this comment.
May I ask if it is better to use 2.1.0 instead of 0.1.0 as the version?
There was a problem hiding this comment.
this file was replaced as a part of the generated files from the swagger sdk.
Arif-lakhani
force-pushed
the
k8s-extension/release-1.5.0
branch
from
10e1709 to
ed41084
Compare
yanzhudd
approved these changes
Oct 10, 2023
|
[Release] Update index.json for extension [ k8s-extension ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=95755&view=results |
bgashirabake
pushed a commit
to bgashirabake/azure-cli-extensions
that referenced
this pull request
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.