-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mesh upgrade commands for az aks mesh #6775
Conversation
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
aks mesh enable | cmd aks mesh enable added parameter revision |
||
aks mesh get-revisions | cmd aks mesh get-revisions added |
||
aks mesh get-upgrades | cmd aks mesh get-upgrades added |
||
aks mesh upgrade | sub group aks mesh upgrade added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -7488,6 +7488,56 @@ def test_aks_azure_service_mesh_with_pluginca(self, resource_group, resource_gro | |||
self.is_empty(), | |||
]) | |||
|
|||
@AllowLargeResponse() | |||
@AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='westus2') | |||
def test_aks_azure_service_mesh_upgrade_commands(self, resource_group, resource_group_location): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems some new test cases were added, queued new live test validation.
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
live test passed
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=96202&view=results |
Add mesh upgrade commands for az aks mesh
az aks mesh get-upgrades -g rg-name -n mc-name
az aks mesh get-revisions -l location
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.