Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update index.json to vmware 0.7.2 #2546

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Conversation

ctaggart
Copy link
Contributor

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/ctaggart/azure-cli-extensions.git@vmware_0.7.1#subdirectory=src/$EXT&egg=$EXT"

@yungezz
Copy link
Member

yungezz commented Oct 20, 2020

hi @qwordy, could you pls help to review?

@qwordy
Copy link
Member

qwordy commented Oct 20, 2020

Please fix linter error

@ctaggart
Copy link
Contributor Author

The fixed those lint errors in pull request #2047 to move the code here. If these lint errors need to be fixed, can we get that pull request merged and released? I can close this one.

Run custom pylint rules.
Running pylint on extensions...
************* Module azext_vmware.commands
/home/vsts/.azure/cliextensions/vmware/azext_vmware/commands.py:17:8: E5001: Show command must use show_command or custom_show_command. (show-command)
/home/vsts/.azure/cliextensions/vmware/azext_vmware/commands.py:31:8: E5001: Show command must use show_command or custom_show_command. (show-command)
/home/vsts/.azure/cliextensions/vmware/azext_vmware/commands.py:37:8: E5001: Show command must use show_command or custom_show_command. (show-command)
/home/vsts/.azure/cliextensions/vmware/azext_vmware/commands.py:43:8: E5001: Show command must use show_command or custom_show_command. (show-command)

@qwordy
Copy link
Member

qwordy commented Oct 20, 2020

The fixed those lint errors in pull request #2047 to move the code here. If these lint errors need to be fixed, can we get that pull request merged and released? I can close this one.

Run custom pylint rules.
Running pylint on extensions...
************* Module azext_vmware.commands
/home/vsts/.azure/cliextensions/vmware/azext_vmware/commands.py:17:8: E5001: Show command must use show_command or custom_show_command. (show-command)
/home/vsts/.azure/cliextensions/vmware/azext_vmware/commands.py:31:8: E5001: Show command must use show_command or custom_show_command. (show-command)
/home/vsts/.azure/cliextensions/vmware/azext_vmware/commands.py:37:8: E5001: Show command must use show_command or custom_show_command. (show-command)
/home/vsts/.azure/cliextensions/vmware/azext_vmware/commands.py:43:8: E5001: Show command must use show_command or custom_show_command. (show-command)

Yes. OK.

@ctaggart ctaggart changed the title update index.json to vmware 0.7.1 update index.json to vmware 0.7.2 Oct 20, 2020
@ctaggart
Copy link
Contributor Author

@qwordy, I fixed the pylint errors and made a new release. Please merge this first. Then let's work on getting the extension moved #2047.

@ctaggart ctaggart mentioned this pull request Oct 21, 2020
3 tasks
@qwordy qwordy merged commit 2f9e2e9 into Azure:master Oct 22, 2020
@ctaggart ctaggart deleted the vmware_0.7.1 branch July 12, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants