Add new command command-change tree-export to export command tree
#448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ReaNAiveD, |
AllyW
reviewed
May 16, 2024
AllyW
reviewed
May 16, 2024
| if not module_loader: | ||
| continue | ||
| module_loader = module_loader[0] | ||
| module_path = module_loader.__class__.__module__ |
There was a problem hiding this comment.
extension module name: azext_spring, azext_amcs etc
There was a problem hiding this comment.
Use _get_command_source to retrieve the extension name.
AllyW
reviewed
May 16, 2024
| if not subtree.get(part): | ||
| subtree[part] = {} | ||
| subtree = subtree[part] | ||
| subtree[parts[-1]] = module_name |
There was a problem hiding this comment.
It would be more clear if expected command tree structure is provided or through test.
AllyW
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I propose to introduce a new command or add new parameters to facilitate the exportation of the command tree.
Once exported, this command tree could be uploaded to our storage account. This would enable the CLI Validation Tool to dynamically load command metadata, significantly improving its functionality and efficiency.