Pin isort and revert pylint #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
Juliehzl,
mmyyrroonn,
fengzhou-msft,
arrownj and
qianwens
mmyyrroonn
reviewed
Jul 8, 2020
| ], | ||
| extras_require={ | ||
| ":python_version<'3.0'": ['pylint==1.9.2', 'futures'], | ||
| ":python_version>='3.0'": ['pylint==2.5.3'] | ||
| ":python_version>='3.0'": ['pylint==2.3.0'] |
There was a problem hiding this comment.
Do we need to release new azdev since the released version is also broken?
There was a problem hiding this comment.
Luckily we currently use the main branch of azdev in Azure CLI CI so the fix will applied. But yes, we do need to release a new version of azdev.
There was a problem hiding this comment.
This version pin issue may exist in other third-party packages, we should look through and pin all of them.
mmyyrroonn
approved these changes
Jul 8, 2020
Juliehzl
approved these changes
Jul 8, 2020
|
we need to add release note in history.rst |
Merged
|
The " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin
isortand revertpylintupdate (#224).No matter whether we use the
mainbranch ofazdevor the released version on PyPI,pylintwill crash withAttributeError: module 'isort' has no attribute 'SortImports', butazdevcan't detect that (another bug). In such case,pylintdoesn't work at all, giving a false positive indicating the style check passed.