Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

NamedValues solve reference in parameters file #846

Merged
merged 6 commits into from
Dec 5, 2022
Merged

NamedValues solve reference in parameters file #846

merged 6 commits into from
Dec 5, 2022

Conversation

f-alizada
Copy link
Collaborator

@f-alizada f-alizada commented Nov 25, 2022 •
edited
Loading

NamedValues

  • solve reference in parameters file
  • Fetch secret values on request
  • Currently secret values will be extracted as well given extractSecrets parameter is set to true
  • Changed mock client configuration from one to many to be able to mock different request within one http client

Solves: #835

@f-alizada f-alizada marked this pull request as ready for review December 2, 2022 13:57
DeagleGross
DeagleGross approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@DeagleGross DeagleGross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/ArmTemplates.Tests/Extractor/Scenarios/NamedValuesExtractorTests.cs Show resolved Hide resolved
@f-alizada f-alizada changed the title [WIP] NamedValues solve reference in parameters file NamedValues solve reference in parameters file Dec 5, 2022
@f-alizada f-alizada merged commit f879768 into Azure:main Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DeagleGross DeagleGross DeagleGross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f-alizada @DeagleGross