Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for minor code scan issues #1619

Merged
merged 8 commits into from
Jun 20, 2023
Merged

Fixes for minor code scan issues #1619

merged 8 commits into from
Jun 20, 2023

Conversation

vgamayunov
Copy link
Collaborator

Fixes for issues reported by SonarQube:

  • repetition of string literal replaced by var
  • removed commented out code
  • split long lines

regression test with local auth and no Grafana - passed

@vgamayunov vgamayunov requested a review from xpillons June 20, 2023 10:37
@xpillons xpillons added the fix label Jun 20, 2023
@vgamayunov vgamayunov merged commit f1802d9 into main Jun 20, 2023
@vgamayunov vgamayunov deleted the fix/code-scan branch June 20, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpillons xpillons xpillons approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vgamayunov @xpillons