Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect to an existing Domain Controller #1454

Merged
merged 64 commits into from
May 4, 2023
Merged

Connect to an existing Domain Controller #1454

merged 64 commits into from
May 4, 2023

Conversation

xpillons
Copy link
Collaborator

@xpillons xpillons commented Mar 31, 2023 •
edited
Loading

Allow an existing Active Directory to be used instead of deploying our own sand box one.

  • New configuration to define the domain to join, domain controllers to contact and Keyvault secret to get the join domain password from
  • fix issue on group membership for users
  • move sudoers and allowed ssh users to the domain join cluster-init script
  • defined azhop-users to be the group for all azhop default users

close #475
close #1223
close #1224
close #749

Known Issues

  • regular users can start nodes but can't stop them => users needs to be added in the CC database
  • rstudio not starting

jchancellor-ms and others added 29 commits March 2, 2023 20:50
@jchancellor-ms
Updated schema, config, and build.sh for existing ad
66b31cb
@jchancellor-ms
updated schema and build script for future ad changes
d8c5bbf
@xpillons
Merge pull request #1423 from jchancellor-ms/issue475-config
ade22b8 
Issue475 use_existing_ad - config file updates
@xpillons
create AD or not based on use_existing_ad
71255b6
@xpillons
dont add AD in inventory if not required
a60ea29
@vgamayunov
replace tf use_existing_ad with generic create_ad
7a44f97
@jchancellor-ms
Terraform changes to allow for existing AD
3640530
@jchancellor-ms
added config and schema update for domain controller ip addresses
0c3c7ed
@jchancellor-ms
Corrected ad subnet duplication
0f70d8b
@jchancellor-ms
corrected bad ad references in locals
5283abb
@jchancellor-ms
Added explicit subnet resource dependencies to netapp volume
cd7b1f7
@xpillons
Merge pull request #1441 from jchancellor-ms/ad_terraform
22bf83c 
AD terraform updates
@xpillons
add missing subnet name
1d4d989
@xpillons
create domain join pwd secret only if required
361f352
@xpillons
cleanup
300049b
@xpillons
add monitor link
afcfd75
@xpillons
use arrays for ad
3841217
@xpillons
dynamic rules for DC access
825ce5b
@xpillons
skip ad install when using an existing one
64081f3
@xpillons
global variables for domain join
39b090d
@xpillons
use domain join admin variable
e3b3947
@xpillons
remove debug flag
550870b
@xpillons
do not use private DNS
6709974
@xpillons
dns records for domain join
71eb95c
@xpillons
dynamic domain name
ca6e67f
@xpillons
use ad join password
d41628d
@xpillons
fix bad index
a451909
@xpillons
set ldap server to i's FQDN
02fe138
@xpillons
build the node array with admin user
0ed4f4c
@xpillons xpillons added this to the Version 1.0.35 milestone Apr 12, 2023
@xpillons xpillons removed this from the Version 1.0.35 milestone Apr 14, 2023
@xpillons xpillons merged commit e49336b into main May 4, 2023
@xpillons xpillons deleted the feature/use_existing_ad branch May 25, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmeiland hmeiland Awaiting requested review from hmeiland

@edwardsp edwardsp Awaiting requested review from edwardsp

@jchancellor-ms jchancellor-ms Awaiting requested review from jchancellor-ms

Assignees
No one assigned
Labels
kind/feature New feature request
Projects
None yet
Milestone
No milestone
3 participants
@xpillons @jchancellor-ms @vgamayunov