feat(dpg): support `logicalPath` of lro #3839

archerzz · 2023-10-16T09:24:25Z

Description

pass in logicalPath info from emitter
in generator, generate convert lambda to fetch the return value from logicalPath
add test case

resolve #3837

Checklist

To ensure a quick review and merge, please ensure:

The PR has a understandable title and description explaining the why and what.
The PR is opened in draft if not ready for review yet.
- If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

Build is completely green
- Submissions with test failures require tracking issue and approval of a CODEOWNER
At least one +1 review by a CODEOWNER
All -1 reviews are confirmed resolved by the reviewer
- Override/Marking reviews stale must be discussed with CODEOWNERS first

# Conflicts: # src/TypeSpec.Extension/Emitter.Csharp/src/lib/operation.ts - pass in `logicalPath` info from emitter - in generator, generate convert lambda to fetch the return value from `logicalPath` - add test case resolve Azure#3837

test/TestProjects/Authoring-TypeSpec/Authoring-TypeSpec.tsp

archerzz · 2023-10-17T13:05:16Z

Regen preview: Azure/azure-sdk-for-net#39323

It also rolls back the workaround for OpenAI: Azure/azure-sdk-for-net@046ae62 (#39323)

src/TypeSpec.Extension/Emitter.Csharp/src/lib/operation.ts

src/AutoRest.CSharp/Common/Input/InputTypes/OperationResponse.cs

src/AutoRest.CSharp/LowLevel/Generation/DpgClientWriter.cs

…gicalPath`

archerzz · 2023-10-18T07:50:27Z

List of changes since last review:

Move ReturnType and ResultPath from OperationResponse to OperationLongRunning.
Use System.Text.Json to fetch the result JSON data, instead of using raw response model to deserialize.
adopt feature/v3 changes

Updated regen preview: Azure/azure-sdk-for-net#39351 The same as the previous one.

test/CadlRanchProjects/azure/core/lro/standard/src/Generated/StandardClient.cs

src/AutoRest.CSharp/LowLevel/Generation/DpgClientWriter.cs

archerzz · 2023-10-19T15:16:38Z

Changes since last review:

return FormattableString to keep type deduction
extract conversion lambda expression into separate methods

Regen preview: Azure/azure-sdk-for-net#39389

test/CadlRanchProjects/azure/core/lro/standard/src/Generated/StandardClient.cs

src/TypeSpec.Extension/Emitter.Csharp/src/lib/operation.ts

src/TypeSpec.Extension/Emitter.Csharp/test/TestProjects/lro/lro.tsp

test/CadlRanchProjects/azure/core/lro/standard/src/Generated/StandardClient.cs

src/AutoRest.CSharp/LowLevel/Output/OperationMethodChainBuilder.cs

src/TypeSpec.Extension/Emitter.Csharp/src/lib/operation.ts

src/AutoRest.CSharp/Common/Input/InputTypes/OperationLongRunning.cs

archerzz · 2023-10-23T06:10:14Z

Changes since last review:

fix typo and add todo
reverse null check for better readability
merge feature/v3

Preview PR: Azure/azure-sdk-for-net#39439

- pass in `logicalPath` info from emitter - in generator, generate conversion method to fetch the return value from `logicalPath` - add test case resolve Azure#3837 --------- Co-authored-by: Mingzhe Huang (from Dev Box) <mingzhehuang@microsoft.com>

archerzz requested review from m-nash, jsquire, lirenhe, ArthurMa1978 and hallipr as code owners October 16, 2023 09:24

archerzz force-pushed the lro/logical-result branch from 8dfddaa to edcbcae Compare October 16, 2023 09:54

feat(dpg): support logicalPath of lro

0479e75

# Conflicts: # src/TypeSpec.Extension/Emitter.Csharp/src/lib/operation.ts - pass in `logicalPath` info from emitter - in generator, generate convert lambda to fetch the return value from `logicalPath` - add test case resolve Azure#3837

archerzz force-pushed the lro/logical-result branch from edcbcae to 0479e75 Compare October 16, 2023 10:10

azure-sdk mentioned this pull request Oct 16, 2023

Autorest Regen Preview to 3.0.0-alpha.20231016.3 by Mingzhe Huang from refs/pull/3839/head Azure/azure-sdk-for-net#39290

Closed

add workaround for https://github.com/Azure/typespec-azure/issues/3725

c3e1ce9

archerzz force-pushed the lro/logical-result branch from fce0404 to c3e1ce9 Compare October 17, 2023 06:33

update Authoring-Typespec to replace unrecommended LRO patch with put

647c114

archerzz force-pushed the lro/logical-result branch from d7045ed to 647c114 Compare October 17, 2023 09:22

azure-sdk mentioned this pull request Oct 17, 2023

Autorest Regen Preview to 3.0.0-alpha.20231017.1 by Mingzhe Huang from refs/pull/3839/head Azure/azure-sdk-for-net#39323

Closed

archerzz commented Oct 17, 2023

View reviewed changes

test/TestProjects/Authoring-TypeSpec/Authoring-TypeSpec.tsp Show resolved Hide resolved

AlexanderSher reviewed Oct 17, 2023

View reviewed changes

src/TypeSpec.Extension/Emitter.Csharp/src/lib/operation.ts Outdated Show resolved Hide resolved

AlexanderSher reviewed Oct 17, 2023

View reviewed changes

src/AutoRest.CSharp/Common/Input/InputTypes/OperationResponse.cs Outdated Show resolved Hide resolved

AlexanderSher reviewed Oct 17, 2023

View reviewed changes

src/AutoRest.CSharp/LowLevel/Generation/DpgClientWriter.cs Outdated Show resolved Hide resolved

Mingzhe Huang (from Dev Box) added 4 commits October 18, 2023 11:16

move ReturnType from OperationResponse to OperationLongRunning

5495657

change to use System.Text.Json to fetch the result specified in `lo…

2d27b85

…gicalPath`

Merge branch 'feature/v3' into lro/logical-result

195ff8d

move ResultPath from OperationResponse to OperationLongRunning

d406803

azure-sdk mentioned this pull request Oct 18, 2023

Autorest Regen Preview to 3.0.0-alpha.20231018.2 by Mingzhe Huang from refs/pull/3839/head Azure/azure-sdk-for-net#39351

Closed

AlexanderSher reviewed Oct 18, 2023

View reviewed changes

test/CadlRanchProjects/azure/core/lro/standard/src/Generated/StandardClient.cs Outdated Show resolved Hide resolved

AlexanderSher reviewed Oct 18, 2023

View reviewed changes

src/AutoRest.CSharp/LowLevel/Generation/DpgClientWriter.cs Outdated Show resolved Hide resolved

Mingzhe Huang (from Dev Box) added 2 commits October 19, 2023 13:49

return FormattableString to enable type deduction in CodeWriter

7085e64

extract result conversion lambda expression into independent method

eed7196

azure-sdk mentioned this pull request Oct 19, 2023

Autorest Regen Preview to 3.0.0-alpha.20231019.1 by Mingzhe Huang from refs/pull/3839/head Azure/azure-sdk-for-net#39389

Closed

archerzz commented Oct 19, 2023

View reviewed changes

test/CadlRanchProjects/azure/core/lro/standard/src/Generated/StandardClient.cs Show resolved Hide resolved

chunyu3 reviewed Oct 20, 2023

View reviewed changes

src/TypeSpec.Extension/Emitter.Csharp/src/lib/operation.ts Show resolved Hide resolved

src/TypeSpec.Extension/Emitter.Csharp/test/TestProjects/lro/lro.tsp Show resolved Hide resolved

test/CadlRanchProjects/azure/core/lro/standard/src/Generated/StandardClient.cs Show resolved Hide resolved

chunyu3 reviewed Oct 20, 2023

View reviewed changes

src/AutoRest.CSharp/LowLevel/Output/OperationMethodChainBuilder.cs Outdated Show resolved Hide resolved

chunyu3 reviewed Oct 20, 2023

View reviewed changes

src/TypeSpec.Extension/Emitter.Csharp/src/lib/operation.ts Show resolved Hide resolved

lirenhe reviewed Oct 20, 2023

View reviewed changes

src/AutoRest.CSharp/Common/Input/InputTypes/OperationLongRunning.cs Outdated Show resolved Hide resolved

Mingzhe Huang (from Dev Box) added 3 commits October 23, 2023 11:11

fix typo and add todo

a5f8246

reverse null check for better readability

48bfafc

Merge branch 'feature/v3' into lro/logical-result

6507ef5

azure-sdk mentioned this pull request Oct 23, 2023

Failed Autorest Regen Preview to 3.0.0-alpha.20231022.2 by Mingzhe Huang from refs/pull/3839/head Azure/azure-sdk-for-net#39439

Closed

Merge branch 'feature/v3' into lro/logical-result

3dd2cf1

lirenhe approved these changes Oct 26, 2023

View reviewed changes

chunyu3 approved these changes Oct 26, 2023

View reviewed changes

Merge branch 'feature/v3' into lro/logical-result

5302c62

archerzz enabled auto-merge (squash) October 26, 2023 09:20

archerzz merged commit 0a56abd into Azure:feature/v3 Oct 26, 2023
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dpg): support `logicalPath` of lro #3839

feat(dpg): support `logicalPath` of lro #3839

archerzz commented Oct 16, 2023

archerzz commented Oct 17, 2023

archerzz commented Oct 18, 2023 •

edited

Loading

archerzz commented Oct 19, 2023

archerzz commented Oct 23, 2023

feat(dpg): support logicalPath of lro #3839

feat(dpg): support logicalPath of lro #3839

Conversation

archerzz commented Oct 16, 2023

Description

Checklist

Ready to Land?

archerzz commented Oct 17, 2023

archerzz commented Oct 18, 2023 • edited Loading

archerzz commented Oct 19, 2023

archerzz commented Oct 23, 2023

feat(dpg): support `logicalPath` of lro #3839

feat(dpg): support `logicalPath` of lro #3839

archerzz commented Oct 18, 2023 •

edited

Loading