Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom api-version #407

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

JDinisHiscox
Copy link
Contributor

Read api version from configuration to allow use of different api versions.

This allows us to support new things like new api properties such as isOnline (https://learn.microsoft.com/en-us/rest/api/apimanagement/current-ga/apis/create-or-update?tabs=HTTP#apicontract).

Read api version from configuration to allow use of different api versions.
@waelkdouh
Copy link
Contributor

Thank you for the PR. Can you please also update the docs to reflect the change to make it clear for users that it's a configuration they can provide?

@JDinisHiscox
Copy link
Contributor Author

JDinisHiscox commented Oct 25, 2023 via email

@JDinisHiscox
Copy link
Contributor Author

JDinisHiscox commented Oct 25, 2023 via email

@JDinisHiscox
Copy link
Contributor Author

@waelkdouh updated the docs 🙂

@waelkdouh
Copy link
Contributor

We will review it and merge accordingly. Thank you.

@guythetechie
Copy link
Contributor

@JDinisHiscox - looks great. For completeness, would you mind adding this configuration to the extractor? You can pretty much copy/paste the publisher changes to the extractor's Program.cs.

@JDinisHiscox
Copy link
Contributor Author

JDinisHiscox commented Oct 25, 2023 via email

@JDinisHiscox
Copy link
Contributor Author

I've added extractor and its docs.

@guythetechie guythetechie added this pull request to the merge queue Oct 25, 2023
Merged via the queue into Azure:main with commit ed746b7 Oct 25, 2023
1 check passed
@guythetechie
Copy link
Contributor

@JDinisHiscox - thanks again for the PR. One thing to note - as new properties get added to different API versions, the API model will need to be updated for the extraction -> publishing flow to work properly. I see your isOnline property in the model, so you should be fine.

@JDinisHiscox
Copy link
Contributor Author

JDinisHiscox commented Oct 25, 2023 via email

@JDinisHiscox JDinisHiscox deleted the jdinis/apiversion-fix branch October 25, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants