Try to fix delete functionality #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed that it fixes #150 Publishing configurations from /home/vsts/work/1/s/Team-XXXX
/home/vsts/work/1
/home/vsts/work/1/s/overrides.sandbox.yaml
info: Publisher[0]
Beginning execution...
info: Publisher[0]
Getting files from commit ID 5b8edbc81dd984fab36acc21bf61540fcd60669a...
info: Microsoft.Hosting.Lifetime[0]
Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
Hosting environment: Production
info: Microsoft.Hosting.Lifetime[0]
Content root path: /home/vsts/work/1/s
info: Publisher[0]
Processing files deleted in commit ID...
info: Publisher[0]
Deleting policy policy in API petstore-v7...
info: Publisher[0]
Deleting API petstore-v7...
info: Publisher[0]
Execution complete.
info: Microsoft.Hosting.Lifetime[0]
Application is shutting down...
Exit code is 0 |
|
@aristosvo thanks. We will review and merge accordingly. |
|
Thank you for identifying the issue and your contribution. PR approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150
Not tested properly! And it only fixes the API object deletion, didn't check other objects. Probably needs to be implemented more generic to be useful.