Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Extract Diagnostic Information per API #616

Closed
DSpirit opened this issue Aug 7, 2024 · 4 comments
Closed

[FEATURE REQ] Extract Diagnostic Information per API #616

DSpirit opened this issue Aug 7, 2024 · 4 comments

Comments

@DSpirit
Copy link
Contributor

DSpirit commented Aug 7, 2024

Please describe the feature.

When specifying custom diagnostic information on API's, the configuration therefore is currently not extracted.
Example configuration:

image

This should be supported from my POV, to be able to process a complete API extraction & deployment.

Copy link

github-actions bot commented Aug 7, 2024

  Thank you for opening this issue! Please be patient while we will look into it and get back to you as this is an open source project. In the meantime make sure you take a look at the [closed issues](https://github.com/Azure/apiops/issues?q=is%3Aissue+is%3Aclosed) in case your question has already been answered. Don't forget to provide any additional information if needed (e.g. scrubbed logs, detailed feature requests,etc.).
  Whenever it's feasible, please don't hesitate to send a Pull Request (PR) our way. We'd greatly appreciate it, and we'll gladly assess and incorporate your changes.

@asimsoroya
Copy link

Thanks for reporting, I am also experiencing this issue.
Also, in sample, can you include full syntax of api and diagnostics I would request in sample config file full properties of API be listed.
I am having difficulty publishing diagnostics as well, though extract pipeline is not generating diagnostics.

@DSpirit
Copy link
Contributor Author

DSpirit commented Aug 8, 2024

Not sure if I get you right, but here's a full response body from a configured applicationInsight diagnostic of an API:
GET https://management.azure.com/subscriptions/***/resourceGroups/***/providers/Microsoft.ApiManagement/service/***/apis/***/diagnostics/applicationinsights?api-version=2022-08-01

{
  "id": "/subscriptions/***/resourceGroups/***/providers/Microsoft.ApiManagement/service/***/apis/***/diagnostics/applicationinsights",
  "type": "Microsoft.ApiManagement/service/apis/diagnostics",
  "name": "applicationinsights",
  "properties": {
    "alwaysLog": "allErrors",
    "httpCorrelationProtocol": "W3C",
    "verbosity": "information",
    "logClientIp": true,
    "loggerId": "/subscriptions/***/resourceGroups/***/providers/Microsoft.ApiManagement/service/***/loggers/ApplicationInsightsLogger",
    "sampling": {
      "samplingType": "fixed",
      "percentage": 100
    },
    "frontend": {
      "request": {
        "headers": [
          "My-Correlation-Id"
        ],
        "body": {
          "bytes": 8192,
          "sampling": null
        }
      },
      "response": {
        "headers": [
          "My-Correlation-Id"
        ],
        "body": {
          "bytes": 8192,
          "sampling": null
        }
      }
    },
    "backend": {
      "request": {
        "headers": [
          "My-Correlation-Id"
        ],
        "body": {
          "bytes": 8192,
          "sampling": null
        }
      },
      "response": {
        "headers": [
          "My-Correlation-Id"
        ],
        "body": {
          "bytes": 8192,
          "sampling": null
        }
      }
    },
    "tags": null
  }
}

@guythetechie
Copy link
Contributor

Thank you, that was an oversight on our part. We'll address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants