Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix init timeout #66

Merged
merged 4 commits into from
Dec 12, 2023
Merged

bug: fix init timeout #66

merged 4 commits into from
Dec 12, 2023

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Dec 11, 2023

Overview/Summary

Updates to init to avoid caching the oidc token.

This PR fixes/adds/changes/removes

  1. Question - getting an AADSTS700024 error during apply stage when using workload identity federation #63

Breaking Changes

None

Testing Evidence

E2E tests run and tested leaving over 1 hour between plan and apply. Also regression tested MSI auth.

Here is an example run that was planned over 8 hours before it was approved for apply:

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate added the bug Something isn't working label Dec 11, 2023
@jaredfholgate jaredfholgate self-assigned this Dec 11, 2023
@jaredfholgate jaredfholgate added the PR: Safe to test 🧪 Enables running of End to End Tests label Dec 11, 2023
@jaredfholgate jaredfholgate merged commit b338f99 into main Dec 12, 2023
28 checks passed
@jaredfholgate jaredfholgate deleted the bug-fix-init-timeout branch December 12, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR: Safe to test 🧪 Enables running of End to End Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant