Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: add system.conf with static JoinControllers configuration #605

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Feb 28, 2019

Reason for Change:

This configuration was recently removed because of systemd release notes announcing deprecation of JoinControllers starting with version 240:

https://lists.freedesktop.org/archives/systemd-devel/2018-December/041852.html

However, Ubuntu 16.04-LTS (current default OS SKU) version of systemd is not using that version:

$ systemd --version
systemd 229
+PAM +AUDIT +SELINUX +IMA +APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT +GNUTLS +ACL +XZ -LZ4 +SECCOMP +BLKID +ELFUTILS +KMOD -IDN

Here is the recently reverted PR:

#410

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/S label Feb 28, 2019
@jackfrancis
Copy link
Member Author

@khenidak for functional review

@CecileRobertMichon who is working on 18.04-LTS integration: which version of systemd will Azure + 18.04-LTS deliver?

@CecileRobertMichon
Copy link
Contributor

This configuration was recently removed

can we link that PR to this one?

which version of systemd will Azure + 18.04-LTS deliver?

I will find out.

@jackfrancis
Copy link
Member Author

@CecileRobertMichon reference to #410 added in (this) PR description

@khenidak
Copy link
Contributor

/lgtm

ps. thanks for accelerating this.

@acs-bot
Copy link

acs-bot commented Feb 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, khenidak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #605 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
+ Coverage   56.68%   56.69%   +<.01%     
==========================================
  Files          91       91              
  Lines       13902    13905       +3     
==========================================
+ Hits         7881     7884       +3     
  Misses       5355     5355              
  Partials      666      666

@acs-bot acs-bot merged commit 6ef7c7e into Azure:master Feb 28, 2019
tariq1890 pushed a commit to tariq1890/aks-engine that referenced this pull request Mar 1, 2019
tariq1890 pushed a commit to tariq1890/aks-engine that referenced this pull request Mar 1, 2019
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants