-
Notifications
You must be signed in to change notification settings - Fork 519
test: enable timeouts for running E2E commands #563
test: enable timeouts for running E2E commands #563
Conversation
Codecov Report
@@ Coverage Diff @@
## master #563 +/- ##
=======================================
Coverage 56.74% 56.74%
=======================================
Files 91 91
Lines 13870 13870
=======================================
Hits 7870 7870
Misses 5336 5336
Partials 664 664 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make the timeout a const parameter where it makes sense?
42b09b4
to
e3d3dab
Compare
what about all the hardcoded 60 second timeouts in cli.go? |
@CecileRobertMichon that's a different timeout enforcement which is ensuring "fail fast" when something goes wonky with pre-requisite The purpose of this changeset is to enable timeouts for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Enable setting an upper bound time limit on E2E test commands. The specific use-case is ensuring that simple pod-to-pod networking operations are consistently quick and don't fall victim to, for example, occasional > 5 second DNS lookup operations.
Issue Fixed:
Requirements:
Notes: