This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
ci: ignore test files in code coverage #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
=========================================
+ Coverage 54.75% 56.7% +1.94%
=========================================
Files 97 91 -6
Lines 14708 13859 -849
=========================================
- Hits 8054 7859 -195
+ Misses 5980 5334 -646
+ Partials 674 666 -8 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
juhacket
pushed a commit
to juhacket/aks-engine
that referenced
this pull request
Mar 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Some files under the
test/directory are being included in aks-engine's code coverage report. Additionally, thepkg/armhelpers/mockclients.goshould be excluded, as it is also test code.Here are the codecov docs for configuring the
ignore:directive.Issue Fixed:
Requirements:
Notes:
The proof for this PR will be in the codecov comment that gets posted.