-
Notifications
You must be signed in to change notification settings - Fork 519
feat: add human-readable output option to "get-versions" command #527
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #527 +/- ##
==========================================
+ Coverage 54.58% 54.66% +0.07%
==========================================
Files 97 97
Lines 14641 14672 +31
==========================================
+ Hits 7992 8020 +28
- Misses 5974 5976 +2
- Partials 675 676 +1 |
lgtm |
/hold I'm adding some tests. Should |
cfd9424
to
41d074b
Compare
Team feedback was that |
lgtm |
I notice that |
I think |
I changed "table" to "human" for parity with the existing $ ./bin/aks-engine get-versions -h
Display supported Kubernetes versions and upgrade versions
Usage:
aks-engine get-versions [flags]
Flags:
-h, --help help for get-versions
-o, --output string Output format. Allowed values: human, json (default "human")
--version string Kubernetes version (optional)
--windows Kubernetes cluster with Windows nodes (optional)
Global Flags:
--debug enable verbose debug logs
$ ./bin/aks-engine version -h
Print the version of AKS Engine
Usage:
aks-engine version [flags]
Flags:
-h, --help help for version
-o, --output string Output format. Allowed values: human, json (default "human")
Global Flags:
--debug enable verbose debug logs |
I'm keeping this PR on hold just so I can merge it myself and ensure the first commit doesn't become the CHANGELOG entry. |
lgtm, ready for admin merge |
…re#527) * refactor: move command implementation to get_versions * feat: add table output option to "get-versions" command * fix: orchestrators command needs defaults * refactor: use fmt.Errorf * test: add cases for json, table, and invalid output formats * feat: make table output the default for "get-versions" * refactor: rename "table" to "human" and sync with versions command * refactor: unify outputFormatOptions and error messages
…re#527) * refactor: move command implementation to get_versions * feat: add table output option to "get-versions" command * fix: orchestrators command needs defaults * refactor: use fmt.Errorf * test: add cases for json, table, and invalid output formats * feat: make table output the default for "get-versions" * refactor: rename "table" to "human" and sync with versions command * refactor: unify outputFormatOptions and error messages
Reason for Change:
The
aks-engine get-versions
command added in #448 defaults to JSON output that is hard to read. This adds the--output=human
argument which acts similarly toaz aks get-versions --output table
:Issue Fixed:
Fixes #520
Requirements:
Notes:
Should we make the table output the default?