Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: increase auto-generated cert expiration to 30 years #396

Conversation

jackfrancis
Copy link
Member

Reason for Change:

For folks not submitting their own certificates, let's increase the expiration of the auto-generated certs we provide for them. In practice, expired certs render a cluster 100% inoperable.

@qike-ms @thomas1206 @jwilder @sauryadas @seanmck FYI

Issue Fixed:

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Jan 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #396 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
- Coverage   53.42%   53.42%   -0.01%     
==========================================
  Files          95       95              
  Lines       14361    14363       +2     
==========================================
  Hits         7673     7673              
- Misses       6025     6027       +2     
  Partials      663      663

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis merged commit dc52324 into Azure:master Feb 2, 2019
@jackfrancis jackfrancis deleted the increase-auto-generated-cert-expiration branch February 2, 2019 01:03
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants