This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: add getter methods for managed identity #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we unit test these? |
|
@jackfrancis Sure thing! |
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
=========================================
+ Coverage 53.23% 53.3% +0.06%
=========================================
Files 95 95
Lines 14230 14236 +6
=========================================
+ Hits 7576 7588 +12
+ Misses 5989 5986 -3
+ Partials 665 662 -3 |
tariq1890
force-pushed
the
k_helpers
branch
2 times, most recently
from
f267773 to
18bdda2
Compare
jackfrancis
reviewed
Jan 23, 2019
jackfrancis
reviewed
Jan 23, 2019
jackfrancis
reviewed
Jan 24, 2019
jackfrancis
reviewed
Jan 24, 2019
jackfrancis
reviewed
Jan 24, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding helper methods to increase reuse of code.