chore: remove commit check from Azure DevOps pipeline #250
Conversation
| @@ -49,7 +49,7 @@ jobs: | |||
| - script: make bootstrap | |||
| displayName: Install dependencies | |||
| workingDirectory: $(modulePath) | |||
| - script: make validate-commit-msg validate-copyright-headers test-style | |||
There was a problem hiding this comment.
should we also remove the script in the Makefile since we're not using it anymore?
There was a problem hiding this comment.
I'd still like to have a way to validate commit messages locally, and IMHO this still works fine for that case. I'll probably use it, but I can rip it out if we'd rather not have the clutter.
|
+1 I like this so much better as a PR check |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
make validate-commit-msgonly looks at the most recent non-merge commit, which can be less than optimal. This removes that check from our Azure DevOps pipeline.Instead let's try the probot semantic pull requests GitHub service. I enabled it and will test it with this PR.
Issue Fixed:
Requirements:
Notes: