chore: update kubernetes-dashboard to v1.10.1 #232
Conversation
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 53.23% 53.23%
=======================================
Files 95 95
Lines 14240 14240
=======================================
Hits 7580 7580
Misses 5994 5994
Partials 666 666 |
| @@ -15,7 +15,7 @@ import ( | |||
| var k8sComponentVersions = map[string]map[string]string{ | |||
| "1.13": { | |||
| "dockerEngine": "1.13.*", | |||
| "dashboard": "kubernetes-dashboard-amd64:v1.10.0", | |||
| "dashboard": "kubernetes-dashboard-amd64:v1.10.1", | |||
There was a problem hiding this comment.
Can you add the new version to the VHD script?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is arguably a breaking change, if you were relying on the mostly useless unauthenticated dashboard view. Should we expose this flag as an addon option? |
|
@mboersma Let's ship w/ the opinionated "no longer able to use unauthenticated dashboard" and see how many folks miss that security hole. |
* chore: update kubernetes-dashboard to v1.10.1 See https://github.com/kubernetes/dashboard/releases/tag/v1.10.1 * test: update expectation in TestAssignDefaultAddonImages * chore: add kubernetes-dashboard:v1.10.1 to VHD script
Reason for Change:
See https://github.com/kubernetes/dashboard/releases/tag/v1.10.1
Issue Fixed:
Requirements:
Notes: