Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: do not check agent & master pool size when using availability zones #206

Merged
merged 1 commit into from
Jan 7, 2019
Merged

fix: do not check agent & master pool size when using availability zones #206

merged 1 commit into from
Jan 7, 2019

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Dec 27, 2018

@acs-bot acs-bot added the size/M label Dec 27, 2018
@acs-bot
Copy link

acs-bot commented Dec 27, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sylr
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tariq1890

If they are not already assigned, you can assign the PR to them by writing /assign @tariq1890 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sylr
Copy link
Contributor Author

sylr commented Dec 27, 2018

/assign @tariq1890

@mboersma mboersma changed the title Do not check agent & master pool size when using availability zones fix: do not check agent & master pool size when using availability zones Dec 31, 2018
@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #206 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   53.18%   53.17%   -0.02%     
==========================================
  Files          95       95              
  Lines       14228    14224       -4     
==========================================
- Hits         7567     7563       -4     
  Misses       5995     5995              
  Partials      666      666

2 similar comments
@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #206 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   53.18%   53.17%   -0.02%     
==========================================
  Files          95       95              
  Lines       14228    14224       -4     
==========================================
- Hits         7567     7563       -4     
  Misses       5995     5995              
  Partials      666      666

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #206 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   53.18%   53.17%   -0.02%     
==========================================
  Files          95       95              
  Lines       14228    14224       -4     
==========================================
- Hits         7567     7563       -4     
  Misses       5995     5995              
  Partials      666      666

@codecov
Copy link

codecov bot commented Jan 2, 2019 •
edited
Loading

Codecov Report

Merging #206 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   53.23%   53.22%   -0.02%     
==========================================
  Files          95       95              
  Lines       14240    14236       -4     
==========================================
- Hits         7581     7577       -4     
  Misses       5994     5994              
  Partials      665      665

@tariq1890
Copy link
Contributor

@sylr Can you rebase this?

@tariq1890 tariq1890 requested a review from ritazh January 5, 2019 18:43
@sylr
Do not check agent & master pool size when using availability zones
3907e24 
You might want to start little and grow over time. You should not be
forced to use at least 2 times the amount of availability zones.

Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
@sylr sylr force-pushed the availability-zones branch from 0e89f4c to 3907e24 Compare January 6, 2019 13:36
@sylr
Copy link
Contributor Author

sylr commented Jan 6, 2019

@tariq1890 rebased

ritazh
ritazh approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tariq1890
Copy link
Contributor

@jackfrancis Requesting you for review and merge.

@jackfrancis
Copy link
Member

/lgtm

@jackfrancis jackfrancis merged commit de3b136 into Azure:master Jan 7, 2019
@CecileRobertMichon CecileRobertMichon mentioned this pull request Jan 7, 2019
Closed
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
@sylr
fix: Do not check agent & master pool size when using availability zo…
b3d4deb 
…nes (Azure#206)
@sylr sylr deleted the availability-zones branch October 16, 2019 07:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ritazh ritazh ritazh approved these changes

@tariq1890 tariq1890 tariq1890 approved these changes

Assignees

@tariq1890 tariq1890

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sylr @acs-bot @tariq1890 @jackfrancis @ritazh