Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: enable timeouts for running E2E commands #563

Merged
merged 5 commits into from
Feb 28, 2019

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Feb 22, 2019

Reason for Change:

Enable setting an upper bound time limit on E2E test commands. The specific use-case is ensuring that simple pod-to-pod networking operations are consistently quick and don't fall victim to, for example, occasional > 5 second DNS lookup operations.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #563 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #563   +/-   ##
=======================================
  Coverage   56.74%   56.74%           
=======================================
  Files          91       91           
  Lines       13870    13870           
=======================================
  Hits         7870     7870           
  Misses       5336     5336           
  Partials      664      664

Copy link
Member

@serbrech serbrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the timeout a const parameter where it makes sense?

@jackfrancis jackfrancis force-pushed the e2e-pod-command-timeout branch from 42b09b4 to e3d3dab Compare February 26, 2019 21:17
@CecileRobertMichon
Copy link
Contributor

what about all the hardcoded 60 second timeouts in cli.go?

@jackfrancis
Copy link
Member Author

@CecileRobertMichon that's a different timeout enforcement which is ensuring "fail fast" when something goes wonky with pre-requisite az commands.

The purpose of this changeset is to enable timeouts for kubectl run-type commands; to be able to detect, for example, regular 5 second name lookups in the pod networking stack.

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 9ea37d8 into Azure:master Feb 28, 2019
@jackfrancis jackfrancis deleted the e2e-pod-command-timeout branch February 28, 2019 05:06
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants