ci: check that last commit message is conformant #237
Conversation
|
This checks the most recent commit, which may not be the commit message used when we squash a PR. So maintainers still need to pay attention when merging. I think this will be useful enforcement in most cases that will keep us from missing things in release notes. But there's a tendency not to follow all these rules when adding commits onto an existing PR, as in: Those type of tacked-on commits will fail now. IDK if that's more annoying than helpful. |
mboersma
force-pushed
the
enforce-commit-messages
branch
from
92c12df to
001eb12
Compare
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
=======================================
Coverage 53.23% 53.23%
=======================================
Files 95 95
Lines 14240 14240
=======================================
Hits 7580 7580
Misses 5994 5994
Partials 666 666 |
|
/hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
* ci: check that last commit message is conformant * fix: echo commit message in case of failure * fix: add --no-merges flag so commit check works
Reason for Change:
Ensures that commits don't slip through which can't be found by
git-chglogor similar release tools that expect conventional commits. Also adds our copyright header validation script to the same linting step.Issue Fixed:
Requirements:
Notes: