Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move collide function to crd package #140

Merged
merged 3 commits into from
Nov 27, 2023
Merged

move collide function to crd package #140

merged 3 commits into from
Nov 27, 2023

Conversation

OliverMKing
Copy link
Collaborator

@OliverMKing OliverMKing commented Nov 27, 2023

Description

Moves the collision check to being exported in our crd package. This is needed so we can create custom webhooks outside this repo that use the same logic.

How Has This Been Tested?

e2e and unit tested.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@OliverMKing OliverMKing changed the title split off collides and default functions move collides and default functions to crd package Nov 27, 2023
@OliverMKing OliverMKing changed the title move collides and default functions to crd package move collide function to crd package Nov 27, 2023
@coveralls
Copy link
Collaborator

coveralls commented Nov 27, 2023

Pull Request Test Coverage Report for Build 7008134673

  • 40 of 42 (95.24%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.4%) to 80.19%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/webhook/nginxingress.go 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
pkg/webhook/nginxingress.go 1 57.38%
Totals Coverage Status
Change from base Build 6948852193: 1.4%
Covered Lines: 2951
Relevant Lines: 3680

💛 - Coveralls

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=53288d8

pkg/webhook/nginxingress.go Show resolved Hide resolved
Copy link
Contributor

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OliverMKing OliverMKing merged commit 7d7000e into Azure:main Nov 27, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants