-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
managed-by label checks for spc, placeholder pods and ingress backend #111
managed-by label checks for spc, placeholder pods and ingress backend #111
Conversation
Pull Request Test Coverage Report for Build 6645361849
💛 - Coveralls |
/ok-to-test sha=7331620 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question re: spc labels
/ok-to-test sha=c3b2dbf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix the upsert thing then i'll approve. looks really good to me
This all looks good to me. We have a few logic branches not covered for one reconciler that we can add tests for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/ok-to-test sha=1ffab9d |
1 similar comment
/ok-to-test sha=1ffab9d |
Description
Added checks for top-level labels to be sure we're managing a resource before deleting
Fixes # (issue)
The Reconcile functions did not check whether or not we owned whatever resource it was currently assessing and could potentially delete secret provider classes and
Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?
Checklist: