Ensure we do have an error before testing it (#4301)

Azure · Nov 28, 2018 · 390f454 · 390f454
1 parent 7e65840
commit 390f454
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/pkg/api/vlabs/validate_test.go b/pkg/api/vlabs/validate_test.go
@@ -1943,11 +1943,13 @@ func TestProperties_ValidateZones(t *testing.T) {
 				ExcludeMasterFromStandardLB: helpers.PointerToBool(test.excludeMasterFromStandardLB),
 			}
 
-			err := p.Validate(false)
-
-			expectedMsg := test.expectedErr
-			if err.Error() != expectedMsg {
-				t.Errorf("expected error with message : %s, but got : %s", expectedMsg, err.Error())
+			if err := p.Validate(false); err != nil {
+				expectedMsg := test.expectedErr
+				if err.Error() != expectedMsg {
+					t.Errorf("expected error with message : %s, but got : %s", expectedMsg, err.Error())
+				}
+			} else {
+				t.Errorf("error should have occurred")
 			}
 		})
 	}