ci: remove aks-engine soak clusters from pr and nightly (#1346)

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>

.pipelines/nightly.yml

@@ -16,14 +16,9 @@ jobs:
     parameters:
       clusterConfigs:
         - "aks"
-        # File names in test/e2e/cluster_configs without file extension
-        - "vmss"
-        - "vmas"
   - template: templates/soak-test.yml
     parameters:
       clusterConfigs:
-        - "pi-vmas-e2e-daily"
-        - "pi-vmss-e2e-daily"
         - "pi-aks-e2e-daily"
   - template: templates/load-test.yml
     parameters:

.pipelines/pr.yml

@@ -19,6 +19,3 @@ jobs:
     parameters:
       clusterConfigs:
         - "aks"
-        # File names in test/e2e/cluster_configs without file extension
-        - "vmss"
-        - "vmas"

.pipelines/templates/e2e-test.yml

@@ -9,7 +9,10 @@ jobs:
   - ${{ each clusterConfig in parameters.clusterConfigs }}:
     - job:
       displayName: ${{ format('{0}', clusterConfig) }}
-      dependsOn: unit_test
+      dependsOn:
+      - scan_images
+      - lint
+      - unit_test
       timeoutInMinutes: 120
       cancelTimeoutInMinutes: 5
       workspace:
@@ -35,9 +38,6 @@ jobs:
         - ${{ if eq(clusterConfig, 'aks') }}:
           - template: deploy-aks-cluster.yml
 
-        - ${{ if not(eq(clusterConfig, 'aks')) }}:
-          - template: deploy-aks-engine-cluster.yml
-
         - template: role-assignment.yml
           parameters:
             identity_resource_group: $(IDENTITY_RESOURCE_GROUP)

.pipelines/templates/unit-test.yml

@@ -1,4 +1,19 @@
 jobs:
+  - job: scan_images
+    timeoutInMinutes: 15
+    workspace:
+      clean: all
+    steps:
+      - template: scan-images.yml
+  - job: lint
+    timeoutInMinutes: 15
+    workspace:
+      clean: all
+    steps:
+      - script: make lint
+        displayName: golangci-lint
+      - script: make helm-lint
+        displayName: helm lint
   - job: unit_test
     timeoutInMinutes: 20
     cancelTimeoutInMinutes: 5
@@ -7,8 +22,3 @@ jobs:
     steps:
       - script: make unit-test
         displayName: Run unit tests
-      - script: make lint
-        displayName: Run lint
-      - script: make helm-lint
-        displayName: Run helm lint
-      - template: scan-images.yml

codecov.yml

@@ -23,10 +23,7 @@ parsers:
       method: no
       macro: no
 
-comment:
-  layout: "header, diff"
-  behavior: default
-  require_changes: no
+comment: false
 
 ignore:
   - "test/**/*.go"

manifest_staging/charts/aad-pod-identity/README.md

@@ -52,7 +52,7 @@ The following steps will help you create a new Azure identity ([Managed Service
 
 ### Prerequisites
 * [Azure Subscription](https://azure.microsoft.com/)
-* [Azure Kubernetes Service (AKS)](https://azure.microsoft.com/services/kubernetes-service/) or [AKS Engine](https://github.com/Azure/aks-engine) deployment
+* [Azure Kubernetes Service (AKS)](https://azure.microsoft.com/services/kubernetes-service/) deployment
 * [kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/) (authenticated to your Kubernetes cluster)
 * [Helm 3](https://v3.helm.sh/)
 * [Azure CLI 2.0](https://docs.microsoft.com/en-us/cli/azure/install-azure-cli?view=azure-cli-latest)

website/content/en/docs/Contributing/_index.md

@@ -19,7 +19,7 @@ When you submit a pull request, a CLA-bot will automatically determine whether y
 
 - Go 1.18
 - Docker
-- an AKS cluster / AKS-Engine cluster
+- an AKS cluster
 - Helm 3
 - A container registry. One of the following would work:
   - Dockerhub