-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arch distro support #670
Conversation
@enihcam, It will cover your contributions to all Microsoft-managed open source projects. |
@enihcam, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small comments
config/arch/waagent.conf
Outdated
# OS.EnableRDMA=y | ||
|
||
# Enable or disable goal state processing auto-update, default is enabled | ||
AutoUpdate.Enabled=n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend you enable this
bin/waagent2.0
Outdated
@@ -1117,7 +1117,148 @@ class oracleDistro(redhatDistro): | |||
def __init__(self): | |||
super(oracleDistro, self).__init__() | |||
|
|||
############################################################ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2.0 library should not need these changes? Typically we do not update this code any more since this version of the agent is no longer supported.
@hglkrijger Thanks for code review. I fixed it according to your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Add Arch distro support. This fixes the issues #653 and #120 .
Looking forward to official Arch images in Azure!
www.archlinux.org