Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arch distro support #670

Merged
merged 6 commits into from
Apr 18, 2017
Merged

Add Arch distro support #670

merged 6 commits into from
Apr 18, 2017

Conversation

enihcam
Copy link
Contributor

@enihcam enihcam commented Apr 15, 2017

Add Arch distro support. This fixes the issues #653 and #120 .

Looking forward to official Arch images in Azure!

www.archlinux.org

@msftclas
Copy link

@enihcam,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@enihcam, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

Copy link
Member

@hglkrijger hglkrijger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments

# OS.EnableRDMA=y

# Enable or disable goal state processing auto-update, default is enabled
AutoUpdate.Enabled=n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend you enable this

bin/waagent2.0 Outdated
@@ -1117,7 +1117,148 @@ class oracleDistro(redhatDistro):
def __init__(self):
super(oracleDistro, self).__init__()

############################################################
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2.0 library should not need these changes? Typically we do not update this code any more since this version of the agent is no longer supported.

@enihcam
Copy link
Contributor Author

enihcam commented Apr 18, 2017

@hglkrijger Thanks for code review. I fixed it according to your suggestion.

Copy link
Member

@hglkrijger hglkrijger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hglkrijger hglkrijger added this to the v2.2.10 milestone Apr 18, 2017
@hglkrijger hglkrijger merged commit ab90f07 into Azure:master Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants