Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled PageBlob support through HostGAPlugin #625

Merged
merged 1 commit into from
Mar 27, 2017
Merged

Enabled PageBlob support through HostGAPlugin #625

merged 1 commit into from
Mar 27, 2017

Conversation

brendandixon
Copy link
Contributor

Signed-off-by: Brendan Dixon brendandixon@me.com

Copy link
Member

@hglkrijger hglkrijger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor comments

else:
return_val = ustr(remove_bom(response.read()), encoding='utf-8')

except HttpError as e:
logger.error("get API versions failed with [{0}]".format(e))
logger.error("HostGAPlugin: Exception Get API verions: " \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versions

headers=self._build_status_headers())

if response.status != httpclient.OK:
raise HttpError("HostGAPlugin: Put Block failed: {0}".format(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put Block Blob?

raise HttpError("HostGAPlugin: Put Block failed: {0}".format(
self._read_response_error(response)))
else:
logger.verbose("HostGAPlugin: Put Block status succeeded")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block Blob?

Signed-off-by: Brendan Dixon <brendandixon@me.com>
@hglkrijger hglkrijger merged commit 7676bf8 into Azure:master Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants