Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache-incarnation sync #587

Merged
merged 7 commits into from
Feb 9, 2017
Merged

Fix cache-incarnation sync #587

merged 7 commits into from
Feb 9, 2017

Conversation

hglkrijger
Copy link
Member

@hglkrijger hglkrijger commented Feb 9, 2017

Recently we added code to store the published hostname on disk, in order to detect a hostname change when the agent is not running. When the agent upgrades at runtime across this boundary, we can initiate a hostname change immediately after provisioning. This resets the network adapter, which can cause the manifest or goalstate download to fail.

In some cases, particularly when installing an extension at provision time, this leads to a state where the agent has recorded the Incarnation as n, but ExtensionsConfig.{n}.xml does not yet exist.

This PR contains several updates:

  • prevent the network adapter from resetting, and causing the initial failure
  • make sure the incarnation is only updated after the cache is stored, in case networking fails for another reason
  • reduce the http verbose logging, so debugging is a little easier
  • in the case of NSG, ensure we force update the goal state
  • update the version to 2.2.5 for publishing
  • fixes waagent cannot handle hostname change and dhcp client restart #585

/cc @brendandixon @jinhyunr

@brendandixon
Copy link
Contributor

LGTM

@hglkrijger hglkrijger merged commit f561aee into Azure:master Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants