Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): ensure waagent service starts after cloud-init.service #3235

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cjp256
Copy link

@cjp256 cjp256 commented Sep 26, 2024

cloud-init.service is responsible for setting up disks during provisioning. Since waagent may perform operations to configure swap, wait until after cloud-init.service is complete.

This effectively updates all distros to match behavior already done for Mariner and Ubuntu.

Description

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

cloud-init.service is responsible for setting up disks during
provisioning.  Since waagent may perform operations to configure
swap, wait until after cloud-init.service is complete.

This effectively updates all distros to match behavior already
done for Mariner and Ubuntu.

Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
@nagworld9
Copy link
Contributor

@cjp256

cloud-init.service is responsible for setting up disks during provisioning. Since waagent may perform operations to configure swap, wait until after cloud-init.service is complete.

if this is the motivation, will after target ensure waagent service start only after cloud-init service finishes disk operation?

@nmeyerhans
Copy link

Note that as of cloud-init 24.3, cloud-init.service no longer exists, having been renamed to cloud-init-network.service. You'll probably want an After= on that service as well. See canonical/cloud-init#5489

@holmanb
Copy link

holmanb commented Oct 11, 2024

Note that as of cloud-init 24.3, cloud-init.service no longer exists, having been renamed to cloud-init-network.service. You'll probably want an After= on that service as well. See canonical/cloud-init#5489

cloud-config.target is ordered after the network stage both before and after 24.3, so if you would prefer to order after a single unit, that should suffice in all cases.

@cjp256
Copy link
Author

cjp256 commented Oct 16, 2024

Note that as of cloud-init 24.3, cloud-init.service no longer exists, having been renamed to cloud-init-network.service. You'll probably want an After= on that service as well. See canonical/cloud-init#5489

cloud-config.target is ordered after the network stage both before and after 24.3, so if you would prefer to order after a single unit, that should suffice in all cases.

Great points! Will update it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants