Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension sequencing scenario #2969
Extension sequencing scenario #2969
Changes from 24 commits
656f863
5633e53
029f5ae
ae3ad4a
705796d
eb4c490
7dcc600
d49bd31
31b0271
46c9eef
2b9de7f
59b509a
189d1a2
a8d77ed
1574afb
b04e06b
8e522b2
9070a5a
106f383
a37e181
4ffa3ee
59691ff
fb52b39
4fd744d
7f3bb7b
2640a7e
ecdb9ad
7e693a1
d826622
0e2ea4f
8cf4d19
6ae88f0
c5e79ae
a45db9c
0c91f6d
c832824
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"e0" needs updating since now we use the counter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ipaddress cannot have upercase characters in it's domain or we hit the following error. Making runbook name lowercase here
Code: InvalidTemplateDeployment Message: The template deployment 'TestDeployment' is not valid according to the validation procedure. The tracking id is '043fde1e-6cff-43ff-85d6-a15dd8f97690'. See inner errors for details. Exception Details: (InvalidDomainNameLabel) The domain name label lisa-WALinuxAgent-20231031-191104-824-e0-n0 is invalid. It must conform to the following regular expression: ^[a-z][a-z0-9-]{1,61}[a-z0-9]$. Code: InvalidDomainNameLabel Message: The domain name label lisa-WALinuxAgent-20231031-191104-824-e0-n0 is invalid. It must conform to the following regular expression: ^[a-z][a-z0-9-]{1,61}[a-z0-9]$. Target: /subscriptions/***/resourceGroups/lisa-WALinuxAgent-20231031-191104-824-e0/providers/Microsoft.Network/publicIPAddresses/e2e-testPublicLbIp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. this is worth adding as a comment in the code