fetch full distro version for mariner #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagworld9
requested review from
narrieta,
ZhidongPeng and
maddieford
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2773 +/- ##
===========================================
- Coverage 71.99% 71.99% -0.01%
===========================================
Files 104 104
Lines 15839 15841 +2
Branches 2265 2266 +1
===========================================
Hits 11404 11404
- Misses 3913 3914 +1
- Partials 522 523 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
narrieta
reviewed
Mar 6, 2023
azurelinuxagent/common/future.py
Outdated
|
|
||
| # Fixing is the problem https://github.com/Azure/WALinuxAgent/issues/2715. Distro.linux_distribution method not retuning full version | ||
| # If best is true, the most precise version number out of all examined sources is returned. | ||
| if osinfo and "mariner" in osinfo[0].lower(): |
There was a problem hiding this comment.
is this a check for None on distro? is it needed?
There was a problem hiding this comment.
Looks like in this context, it's not needed. Initially thought, we may have empty list but above we are appending some value. So, it will never be empty. I'll update
narrieta
approved these changes
Mar 6, 2023
maddieford
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing the issue #2715.
distro.linux_distribution()not returning full distro version.Issue #
PR information
Quality of Code and Contribution Guidelines