Additional telemetry for goal state #2675
Conversation
Codecov Report
@@ Coverage Diff @@
## release-2.9.0.0 #2675 +/- ##
===================================================
+ Coverage 71.95% 71.98% +0.02%
===================================================
Files 103 103
Lines 15681 15698 +17
Branches 2245 2245
===================================================
+ Hits 11284 11300 +16
- Misses 3880 3881 +1
Partials 517 517
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| if len(certs.warnings) > 0: | ||
| self.logger.warn(certs.warnings) | ||
| add_event(op=WALAEventOperation.GoalState, message=certs.warnings) | ||
| self._history.save_certificates(json.dumps(certs.summary)) | ||
|
|
There was a problem hiding this comment.
Do you think it's useful to add?
There was a problem hiding this comment.
I left that one out, but I can add it if you think it'd be useful. If the operation fails we would get telemetry for the ProtocolError, otherwise we can assume it completed successfully.
There was a problem hiding this comment.
I'd add to avoid assumption. Especially it's useful for on callers or somebody who queries our data without knowing our code.
There was a problem hiding this comment.
In general, the telemetry skips successful operations (when possible) and reports only errors, but I'll go ahead and add this one
There was a problem hiding this comment.
I agree. Since we are adding related information, I thought this would be useful to avoid confusion. Thanks for the change.
| if len(certs.warnings) > 0: | ||
| self.logger.warn(certs.warnings) | ||
| add_event(op=WALAEventOperation.GoalState, message=certs.warnings) | ||
| self._history.save_certificates(json.dumps(certs.summary)) | ||
|
|
There was a problem hiding this comment.
I agree. Since we are adding related information, I thought this would be useful to avoid confusion. Thanks for the change.
* Additional telemetry for goal state * add success message Co-authored-by: narrieta <narrieta> (cherry picked from commit e7641bd)
There are some important messages wrt the Goal State that are written only to the local log. Adding telemetry for those.