Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUSE: Fix valid values for DHCLIENT_HOSTNAME_OPTION #2643

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

nagworld9
Copy link
Contributor

Description

According to wicked's source agent should support all three types ("AUTO", 'AUTO', and AUTO). If it matches, agent shouldn't update the hostname.

This work is addressing the GitHub issue #2614

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #2643 (bde37e0) into develop (05d44c8) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #2643   +/-   ##
========================================
  Coverage    71.91%   71.91%           
========================================
  Files          103      103           
  Lines        15654    15654           
  Branches      2494     2494           
========================================
  Hits         11258    11258           
  Misses        3880     3880           
  Partials       516      516           
Impacted Files Coverage Δ
azurelinuxagent/common/osutil/suse.py 45.65% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nagworld9 nagworld9 merged commit aa9b0e1 into Azure:develop Aug 4, 2022
@nagworld9 nagworld9 deleted the TASK-14874468 branch August 4, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants