Update Log Collector default in Comments and Readme #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinclark19a
requested review from
narrieta,
ZhidongPeng,
dhivyaganesan and
nagworld9
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2608 +/- ##
========================================
Coverage 71.92% 71.92%
========================================
Files 103 103
Lines 15577 15577
Branches 2478 2478
========================================
Hits 11203 11203
Misses 3864 3864
Partials 510 510 Continue to review full report at Codecov.
|
narrieta
reviewed
Jun 8, 2022
README.md
Outdated
| @@ -455,7 +455,7 @@ _Default: y_ | |||
|
|
|||
| If set, agent logs will be periodically collected and uploaded to a secure location for improved supportability. | |||
|
|
|||
| NOTE: This feature is only supported ubuntu 16.04+; this flag will not take effect on any other distro. | |||
| NOTE: This feature is only supported on ubuntu 16.04+, RHEL 7.4+, and centos 7.4+; this flag will not take effect on any other distro. | |||
There was a problem hiding this comment.
I would not list the explicit distros, but just mention that is not supported on all distros, or its dependency on the resource usage feature
collector's dependencies.
narrieta
approved these changes
Jun 8, 2022
nagworld9
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing issue #2603. Comments in code indicate the wrong default value for the log collector.
Additionally, updated the list of distros supported by the log collector
PR information
Quality of Code and Contribution Guidelines