Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset dhcp config to send host information on SUSE distros #2583

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

rjschwei
Copy link
Contributor

@rjschwei rjschwei commented May 5, 2022

  • Reset the dhcp configuration to send the host information when an instance
    is being deprovisioned. This ensures that instances from a managed VM
    created from a running instance send the proper information to the DHCP
    server. Thanks Joao Silva.

Description

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

- Reset the dhcp configuration to send the host information when an instance
  is being deprovisioned. This ensures that instances from a managed VM
  created from a running instance send the proper information to the DHCP
  server. Thanks Joao Silva.
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2583 (f053212) into develop (1d434f9) will decrease coverage by 0.01%.
The diff coverage is 45.45%.

@@             Coverage Diff             @@
##           develop    #2583      +/-   ##
===========================================
- Coverage    71.89%   71.87%   -0.02%     
===========================================
  Files          103      104       +1     
  Lines        15515    15526      +11     
  Branches      2467     2469       +2     
===========================================
+ Hits         11155    11160       +5     
- Misses        3860     3865       +5     
- Partials       500      501       +1     
Impacted Files Coverage Δ
azurelinuxagent/pa/deprovision/factory.py 54.54% <33.33%> (-3.35%) ⬇️
azurelinuxagent/pa/deprovision/suse.py 50.00% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d434f9...f053212. Read the comment docs.

@narrieta
Copy link
Member

narrieta commented Aug 2, 2022

@anhvoms could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants