Added support for devuan linux distribution #2553

peter9370 · 2022-04-14T12:20:58Z

Description

Issue #

Added support for linux distribution devuan

Will only work on devuan version 4 (chimaera) or later. In earlier versions of devuan, waagent uses the python module platform.linux_distribution to get the distribution details. If run under devuan, this incorrectly reports "debian" as the distro.

Devuan version 4 uses python 3.9, and in this, platform.linux_distribution has been removed, forcing waagent to use
distro.linux_distribution instead: this correctly identifies devuan.

PR information

[y ] The title of the PR is clear and informative.
[y] There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
If applicable, the PR references the bug/issue that it fixes in the description.
[y ] New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

[y ] I have read the contribution guidelines.

(Will only work with Devuan >= 4 (Chimaera) - reason is that in Devuan < 4, the platform.linux_distribution module is used to get distro details - and this module is unable to distinguish between Debian and Devuan. In Chimaera, python3 is 3.9, and in this, platform.linux_distribution has been removed, so that distro details are obtained using distro.linux_distribution - which is able to distinguish between Debian and Devuan) Details: - added azurelinuxagent/common/osutil/devuan.py - modified azurelinuxagent/common/osutil/factory.py to use devuan.py - added init and config files for devuan - modified setup.py for devuan support - modified tests/common/osutil/test_factory.py to test devuan support

narrieta

Thanks for the updated PR, and sorry the long, long delay getting to this.

LGTM, but have a few questions/comments that I posted in my review.

Thanks again.

narrieta · 2022-04-29T15:45:44Z

config/devuan/waagent.conf

+# Add firewall rules to protect access to Azure host node services
+# Note:
+# - The default is false to protect the state of existing VMs
+OS.EnableFirewall=n


we do not recommend disabling this, what is the motivation for defaulting to false?

Hi Norberto, thanks for looking into the changes for this pull request.

I based the default waagent.conf for devuan on the one for debian, and this appears to be the only one in which OS.EnableFirewall is disabled. I'm happy to enable it in the waagent.conf for devuan

I've just uploaded three changes to the devuan_support_new branch. The changes include setting waagent.conf to default to OS.EnableFirewall to y

azurelinuxagent/common/osutil/devuan.py

narrieta · 2022-04-29T20:44:32Z

init/devuan/walinuxagent

+# non-daemon instances of waagent may be running concurrently (e.g. when
+# "waagent -deprovision" is being run) and attempts to ensure that any
+# non-daemon instances are preserved when the daemon instance is stopped.
+# 


is this the motivation for the checks on the pid file? i'm a little concerned about those because we are planning on re-structuring the agent and may not need a pid file, and not having that file may affect this script.

in particular "waagent -deprovision" should not be executed while the agent service is running, since a running agent may re-create part of the state that deprovision is trying to delete,

The new init script was based on observations whilst trying waagent on a local test VM - I noticed that using the existing init script, an attempt to stop waagent also killed an instance which was running in a terminal. I can't remember what the terminal instance was running - it wasn't a deprovision. The script was an attempt to cope with any foreseeable possibility - maybe it addresses possibilities which couldn't actually exist in practice.

I wondered about rewriting the script so that it doesn't rely on PID files, and works out which are the daemon and non-daemon instances just from the output of the ps command. That should insulate it against any possibility that the use of pidfiles could be dropped in future.

I've just uploaded a new version of the devuan init script - I've rewritten it completely to remove all references to, and operations on, a pid file: it now operates only on the basis of output from the ps command.

thanks for the update

… pidfile, and simplified status to reflect this

narrieta

a couple of minor comments (about commented-out code), but LGTM

i'll do an automation run tomorrow morning

thanks for your contribution. and sorry again for all the delays

narrieta · 2022-05-16T23:40:24Z

init/devuan/walinuxagent

+	local NDPIDLIST i NDPIDCT
+	declare -a NDPIDLIST
+	debugmsg "check_non_daemon_instance: after init, #NDPIDLIST=${#NDPIDLIST[*]}"
+#	NDPIDLIST=$(	ps ax |


left-over code?

I've now removed the commented-out lines (I'd only retained them for reference during local testing).

narrieta · 2022-05-16T23:41:32Z

init/devuan/walinuxagent

+			# just start waagent
+			debugmsg "start_waagent: waagent is not currently running"
+			log_daemon_msg "Starting ${NAME} daemon"
+#			start-stop-daemon --start --quiet --pidfile ${PIDFILE} --background  --name "${NAME}" --exec ${INTERPRETER} -- ${DAEMON} ${DAEMON_ARGS}


I've now removed the commented-out code lines - only retained for reference during local testing.

narrieta · 2022-05-16T23:43:41Z

init/devuan/walinuxagent

+			debugmsg "start_waagent: trying to stop waagent first, and then start it"
+			stop_waagent
+			log_daemon_msg "Starting ${NAME} daemon"
+#			start-stop-daemon --start --quiet --pidfile ${PIDFILE} --background --name ${NAME} --exec ${INTERPRETER} -- ${DAEMON} ${DAEMON_ARGS}


I've now removed the commented-out codelines - I'd retained them for reference during local testing

narrieta · 2022-05-16T23:45:09Z

init/devuan/walinuxagent

+# non-daemon instances of waagent may be running concurrently (e.g. when
+# "waagent -deprovision" is being run) and attempts to ensure that any
+# non-daemon instances are preserved when the daemon instance is stopped.
+# 


thanks for the update

codecov · 2022-05-16T23:50:24Z

Codecov Report

Merging #2553 (e2d16e0) into develop (b8ca432) will decrease coverage by 0.01%.
The diff coverage is 62.96%.

@@             Coverage Diff             @@
##           develop    #2553      +/-   ##
===========================================
- Coverage    71.90%   71.88%   -0.02%     
===========================================
  Files          102      103       +1     
  Lines        15476    15503      +27     
  Branches      2464     2466       +2     
===========================================
+ Hits         11128    11145      +17     
- Misses        3848     3858      +10     
  Partials       500      500

Impacted Files	Coverage Δ
azurelinuxagent/common/osutil/devuan.py	`58.33% <58.33%> (ø)`
azurelinuxagent/common/osutil/factory.py	`93.10% <100.00%> (+0.24%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ca432...e2d16e0. Read the comment docs.

kevinclark19a

LGTM, waiting for end-to-end testing to merge.

narrieta · 2022-05-18T15:10:34Z

@peter9370 Automation looks OK. Would you check my comments wrt commented-out code and update as needed? I can merge after that. Thanks!

…d up some comments

peter9370 · 2022-05-18T15:59:44Z

@narrieta Thanks for that - yes, sorry, I had left in some commented-out code lines in the walinuxagent init script: it was mainly for reference in local testing. I've removed the commented-out lines now, and also tidied up a few comments.

No worries about the delay in reviewing the pull request - I know things have been hard in the past two years.

narrieta · 2022-05-18T16:24:25Z

@peter9370 thank for this PR!

peter9370 · 2022-05-19T15:11:26Z

@narrieta You're welcome - thanks for reviewing and merging my changes.

peter9370 · 2022-09-02T15:43:03Z

@narrieta Hi Norberto - do you have any idea when the changes to include devuan support will be included in a release?

narrieta · 2022-09-02T16:51:28Z

@peter9370 We should start our next release within 2-3 weeks and this commit will be included there.

peter9370 requested review from narrieta, larohra, kevinclark19a, ZhidongPeng, dhivyaganesan and nagworld9 as code owners April 14, 2022 12:20

narrieta changed the base branch from master to develop April 15, 2022 15:13

narrieta self-assigned this Apr 15, 2022

peter9370 force-pushed the devuan_support_new branch from d500689 to d7b3d60 Compare April 20, 2022 15:57

narrieta reviewed Apr 29, 2022

View reviewed changes

peter9370 added 3 commits May 16, 2022 10:46

waagent.conf - changed default for OS.EnableFirewall to y

d287232

devuan.py - removed unused module imports

3e30fab

init/devuan/walinuxagent: removed all operations on and references to…

d4ac6f3

… pidfile, and simplified status to reflect this

narrieta reviewed May 16, 2022

View reviewed changes

kevinclark19a previously approved these changes May 17, 2022

View reviewed changes

init/devuan/walinuxagent: removed commented-out code lines, and tidie…

b6ab267

…d up some comments

peter9370 dismissed kevinclark19a’s stale review via b6ab267 May 18, 2022 15:54

narrieta approved these changes May 18, 2022

View reviewed changes

Merge branch 'develop' into devuan_support_new

e2d16e0

narrieta merged commit cd3b6d2 into Azure:develop May 18, 2022

peter9370 mentioned this pull request Jun 15, 2022

Not working in devuan ascii #1843

Closed

peter9370 referenced this pull request in MicrosoftDocs/azure-docs Jul 14, 2022

Fixes AB#1941665

2bb3d55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for devuan linux distribution #2553

Added support for devuan linux distribution #2553

peter9370 commented Apr 14, 2022 •

edited

Loading

narrieta left a comment

narrieta Apr 29, 2022

peter9370 May 11, 2022

peter9370 May 16, 2022

narrieta Apr 29, 2022

peter9370 May 11, 2022

peter9370 May 16, 2022

narrieta May 16, 2022

narrieta left a comment

narrieta May 16, 2022

peter9370 May 18, 2022

narrieta May 16, 2022

peter9370 May 18, 2022

narrieta May 16, 2022

peter9370 May 18, 2022

narrieta May 16, 2022

codecov bot commented May 16, 2022 •

edited

Loading

kevinclark19a left a comment

narrieta commented May 18, 2022

peter9370 commented May 18, 2022

narrieta commented May 18, 2022

peter9370 commented May 19, 2022

peter9370 commented Sep 2, 2022

narrieta commented Sep 2, 2022

Added support for devuan linux distribution #2553

Added support for devuan linux distribution #2553

Conversation

peter9370 commented Apr 14, 2022 • edited Loading

Description

PR information

Quality of Code and Contribution Guidelines

narrieta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

narrieta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented May 16, 2022 • edited Loading

Codecov Report

kevinclark19a left a comment

Choose a reason for hiding this comment

narrieta commented May 18, 2022

peter9370 commented May 18, 2022

narrieta commented May 18, 2022

peter9370 commented May 19, 2022

peter9370 commented Sep 2, 2022

narrieta commented Sep 2, 2022

peter9370 commented Apr 14, 2022 •

edited

Loading

codecov bot commented May 16, 2022 •

edited

Loading